Issue 181013012: Remove RenderTheme::supportsDataListUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181013012: Remove RenderTheme::supportsDataListUI. (Closed)

Created:
6 years, 9 months ago by tkent

Modified:
6 years, 9 months ago

Reviewers:
keishi

CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove RenderTheme::supportsDataListUI. The purpose of the funciton was to describe support differences between desktop platforms and Android. Android Chrome now supports same input types for <datalist>. We don't need the function any longer. Note for BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree: |shouldAddPickerIndicator| is always true. We can remove it. BUG=none TEST=none; no behaivor changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168603

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -38 lines)			Patch
M	Source/core/html/forms/BaseDateAndTimeInputType.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp	View	1 chunk	+4 lines, -11 lines	0 comments	Download
M	Source/core/html/forms/ColorInputType.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/forms/InputType.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/forms/InputType.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/html/forms/RangeInputType.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/forms/TextFieldInputType.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderTheme.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderTheme.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/181013012/1

6 years, 9 months ago (2014-03-06 04:28:42 UTC) #4

Message was sent while issue was closed.

Change committed as 168603

Expand Messages | Collapse Messages