Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 181013011: Fix Linux Aura drag-and-drop cancellation. (Closed)

Created:
6 years, 9 months ago by msw
Modified:
6 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su
Visibility:
Public.

Description

Fix Linux Aura drag-and-drop cancellation. Fixes Escape key drag-and-drop cancellation handling. (this is a followup fix for Issue 344289 and r254289) SendXdndLeave(source_current_window_) in OnMoveLoopEnded. (seems like a misnomer, this is the target drop window) (alerts the target window to repaint and cleanup, etc.) BUG=349151, 344289 TEST=Dragging text, bookmarks, etc. from a Linux Aura browser window to the same window, other Chrome windows, and other application is cancelled correctly when pressing [Esc] (no lingering drop indicator, etc.). R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255449

Patch Set 1 #

Patch Set 2 : Try fixing bookmarks too; need another approach. #

Patch Set 3 : Nix OnDragDone changes; rely on OnDragExited, NotifyDragLeave, OnMoveLoopEnded. #

Patch Set 4 : SendXdndLeave to source_current_window_ in OnMoveLoopEnded too. #

Patch Set 5 : Revert BookmarkBarView changes; remove NotifyDragLeave call. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
msw
Hey Elliot and Scott, please take a look; thanks!
6 years, 9 months ago (2014-03-06 03:14:45 UTC) #1
sky
You don't need me for this, erg is fine. -sky
6 years, 9 months ago (2014-03-06 16:37:19 UTC) #2
msw
Right on, please take a look Elliot, the solution was simpler than anticipated.
6 years, 9 months ago (2014-03-06 17:55:17 UTC) #3
Elliot Glaysher
On 2014/03/06 17:55:17, msw wrote: > Right on, please take a look Elliot, the solution ...
6 years, 9 months ago (2014-03-06 18:05:31 UTC) #4
msw
The CQ bit was checked by msw@chromium.org
6 years, 9 months ago (2014-03-06 18:15:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/181013011/70001
6 years, 9 months ago (2014-03-06 18:16:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/181013011/70001
6 years, 9 months ago (2014-03-06 20:54:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/181013011/70001
6 years, 9 months ago (2014-03-06 21:42:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/181013011/70001
6 years, 9 months ago (2014-03-06 22:17:54 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 22:29:39 UTC) #10
Message was sent while issue was closed.
Change committed as 255449

Powered by Google App Engine
This is Rietveld 408576698