src/runtime.cc - Issue 181013008: Runtime::RunMicrotask should silent return if no pending microtask work (rather than asserting)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 181013008: Runtime::RunMicrotask should silent return if no pending microtask work (rather than asserting) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 306042f4ea65601e0e4ed3c5fe57ee08937be87c..ba21345aefd65b99f04220f00b46d78e5e17194a 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -14685,7 +14685,8 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_SetMicrotaskPending) {

RUNTIME_FUNCTION(MaybeObject*, Runtime_RunMicrotasks) {

HandleScope scope(isolate);

ASSERT(args.length() == 0);

- Execution::RunMicrotasks(isolate);

+ if (isolate->microtask_pending())

+ Execution::RunMicrotasks(isolate);

return isolate->heap()->undefined_value();

}

« no previous file with comments | « no previous file | test/mjsunit/fuzz-natives-part3.js » ('j') | no next file with comments »