Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 181011: [Mac] Make I-beam cursor match editing area. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

[Mac] Make I-beam cursor match editing area. Due to our tweaking of the text area, the I-beam cursor was sometimes janky. http://crbug.com/20238 TEST=I don't even know how to really test this.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/browser/cocoa/autocomplete_text_field_cell.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_cell.mm View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm View 5 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
The funniest thing is that it is still janky ... but when I go compare ...
11 years, 3 months ago (2009-08-28 22:08:09 UTC) #1
Scott Hess - ex-Googler
On 2009/08/28 22:08:09, shess wrote: > The funniest thing is that it is still janky ...
11 years, 3 months ago (2009-09-02 21:00:08 UTC) #2
rohitrao (ping after 24h)
LGTM If this makes things look silly, we'll try something else =)
11 years, 3 months ago (2009-09-03 17:47:28 UTC) #3
Scott Hess - ex-Googler
11 years, 3 months ago (2009-09-03 17:50:20 UTC) #4
Things are made marginally less silly.  The important thing is that if
someone later screws with the baseline, the tracking rect will track.

-scott


On Thu, Sep 3, 2009 at 10:47 AM, <rohitrao@chromium.org> wrote:
> LGTM
>
> If this makes things look silly, we'll try something else =)
>
> http://codereview.chromium.org/181011
>

Powered by Google App Engine
This is Rietveld 408576698