Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1810103003: Analyzer directory recursing (tk 2) (#25129). (Closed)

Created:
4 years, 9 months ago by pquitslund
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Analyzer directory recursing (tk 2) (#25129). Take 2 with a fix that addresses a regression in batch-mode. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/b6a1d754444b9976c385a35563c48f500254d6fc

Patch Set 1 #

Patch Set 2 : master merge #

Patch Set 3 : re-apply tk 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -106 lines) Patch
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 9 chunks +56 lines, -21 lines 1 comment Download
M pkg/analyzer_cli/lib/src/error_formatter.dart View 1 2 3 chunks +86 lines, -73 lines 0 comments Download
M pkg/analyzer_cli/lib/src/package_analyzer.dart View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer_cli/test/reporter_test.dart View 1 2 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
4 years, 9 months ago (2016-03-17 17:53:30 UTC) #2
pquitslund
Merged w/ master. PTAL?
4 years, 9 months ago (2016-03-17 18:55:08 UTC) #3
pquitslund
https://codereview.chromium.org/1810103003/diff/40001/pkg/analyzer_cli/lib/src/driver.dart File pkg/analyzer_cli/lib/src/driver.dart (right): https://codereview.chromium.org/1810103003/diff/40001/pkg/analyzer_cli/lib/src/driver.dart#newcode191 pkg/analyzer_cli/lib/src/driver.dart:191: sourcesToAnalyze.add(source); FYI: here's the change. The previous version had ...
4 years, 9 months ago (2016-03-17 18:55:55 UTC) #4
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-17 19:03:04 UTC) #5
pquitslund
4 years, 9 months ago (2016-03-18 16:19:40 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
b6a1d754444b9976c385a35563c48f500254d6fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698