Issue 1810103002: Always use recvmmsg or recvmsg if it's available, and consolidate ReadAndDispatchPackets and ReadAn…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1810103002: Always use recvmmsg or recvmsg if it's available, and consolidate ReadAndDispatchPackets and ReadAn… (Closed)

Created:
4 years, 9 months ago by fnk

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@116987771

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Always use recvmmsg or recvmsg if it's available, and consolidate ReadAndDispatchPackets and ReadAndDispatchSinglePacket into a single API. Not flag protected. No functional change. Note that this does somewhat reduce the test coverage of QuicServerTest, now requiring that changes to QuicPacketReader::ReadAndDispatchSinglePacket be run on platforms that don't support recvmmsg. Merge internal change: 117245279 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -50 lines)			Patch
M	net/tools/quic/quic_client.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_client.cc	View	3 chunks	+3 lines, -14 lines	0 comments	Download
M	net/tools/quic/quic_packet_reader.h	View	1 chunk	+11 lines, -5 lines	0 comments	Download
M	net/tools/quic/quic_packet_reader.cc	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_server.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_server.cc	View	4 chunks	+3 lines, -17 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_server_peer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/tools/quic/test_tools/quic_server_peer.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Depends on Patchset:

Issue 1810073002 Patch 1

Dependent Patchsets:

Issue 1808013003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages