Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1810083003:
Inline fast-path interceptor access in the IC utilities (Closed)
|
Created:
4 years, 9 months ago by Toon Verwaest Modified:
4 years, 9 months ago Reviewers:
Jakob Kummerow CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionInline fast-path interceptor access in the IC utilities
BUG=
Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634
Cr-Commit-Position: refs/heads/master@{#34892}
Committed: https://crrev.com/47f64a76c5758e3f80734f2af865220709cc0de8
Cr-Commit-Position: refs/heads/master@{#34944}
Patch Set 1 #
Total comments: 1
Patch Set 2 : #Patch Set 3 : rebase #Patch Set 4 : Only use StorePropertyWithInterceptor for masking interceptors on the receiver #Patch Set 5 : Also LoadPropertyWithInterceptor #Patch Set 6 : #Messages
Total messages: 23 (11 generated)
verwaest@chromium.org changed reviewers: + jkummerow@chromium.org
ptal. also other paths added now
LGTM https://codereview.chromium.org/1810083003/diff/1/src/ic/ic.cc File src/ic/ic.cc (right): https://codereview.chromium.org/1810083003/diff/1/src/ic/ic.cc#newcode2855 src/ic/ic.cc:2855: // Return the undefined result if no reference error was thrown. nit: I preferred s/was/should be/, cf. condition check in line 2859. Then again the comment just reiterates what the function name is already telling us, so it can also be dropped entirely.
dropped it.
The CQ bit was checked by verwaest@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/1810083003/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810083003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Inline fast-path interceptor access in the IC utilities BUG= ========== to ========== Inline fast-path interceptor access in the IC utilities BUG= Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 Cr-Commit-Position: refs/heads/master@{#34892} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 Cr-Commit-Position: refs/heads/master@{#34892}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1819433003/ by machenbach@chromium.org. The reason for reverting is: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....
Message was sent while issue was closed.
Patchset #4 (id:60001) has been deleted
Message was sent while issue was closed.
Patchset #4 (id:80001) has been deleted
Message was sent while issue was closed.
PTAL again. Now I disabled the runtime function for non-masking interceptors since the prototype chain isn't checked.
Message was sent while issue was closed.
Patchset #6 (id:140001) has been deleted
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Description was changed from ========== Inline fast-path interceptor access in the IC utilities BUG= Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 Cr-Commit-Position: refs/heads/master@{#34892} ========== to ========== Inline fast-path interceptor access in the IC utilities BUG= Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 Cr-Commit-Position: refs/heads/master@{#34892} ==========
The CQ bit was checked by verwaest@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810083003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810083003/160001
Message was sent while issue was closed.
Description was changed from ========== Inline fast-path interceptor access in the IC utilities BUG= Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 Cr-Commit-Position: refs/heads/master@{#34892} ========== to ========== Inline fast-path interceptor access in the IC utilities BUG= Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 Cr-Commit-Position: refs/heads/master@{#34892} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Inline fast-path interceptor access in the IC utilities BUG= Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 Cr-Commit-Position: refs/heads/master@{#34892} ========== to ========== Inline fast-path interceptor access in the IC utilities BUG= Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 Cr-Commit-Position: refs/heads/master@{#34892} Committed: https://crrev.com/47f64a76c5758e3f80734f2af865220709cc0de8 Cr-Commit-Position: refs/heads/master@{#34944} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/47f64a76c5758e3f80734f2af865220709cc0de8 Cr-Commit-Position: refs/heads/master@{#34944} |
