Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1810043004: [Coverage] Add sancov_formatter unittest for split. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Coverage] Add sancov_formatter unittest for split. Unittest for feature added in: https://codereview.chromium.org/1808663002/ BUG=chromium:568949 LOG=n NOTRY=true Committed: https://crrev.com/b954b187198ad7a5311248224f0dd75fb5913320 Cr-Commit-Position: refs/heads/master@{#34923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M tools/sanitizers/sancov_formatter.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/sanitizers/sancov_formatter_test.py View 3 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL
4 years, 9 months ago (2016-03-18 10:28:26 UTC) #4
kjellander_chromium
lgtm
4 years, 9 months ago (2016-03-18 10:32:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810043004/1
4 years, 9 months ago (2016-03-21 09:21:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 09:23:27 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 09:24:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b954b187198ad7a5311248224f0dd75fb5913320
Cr-Commit-Position: refs/heads/master@{#34923}

Powered by Google App Engine
This is Rietveld 408576698