Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1810033004: Use LLVM LTO instead of IR types to improve compatibility (Closed)

Created:
4 years, 9 months ago by Petr Hosek
Modified:
4 years, 9 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com, Ankur Mittal
Base URL:
https://chromium.googlesource.com/a/native_client/pnacl-clang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use LLVM LTO instead of IR types to improve compatibility LLVM IR types use ".ll" and ".bc" suffixes which can break compatiblity with the existing software, so we switch to the LLVM LTO types instead which use the standard ".s" and ".o" suffixes. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347 R=dschuff@chromium.org Committed: d57a6f8b109145f0732906ff94c0380c0ee41953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/Driver/Driver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Petr Hosek
4 years, 9 months ago (2016-03-17 22:04:40 UTC) #3
Derek Schuff
On 2016/03/17 22:04:40, Petr Hosek wrote: This looks fine but what do you mean by ...
4 years, 9 months ago (2016-03-18 00:19:12 UTC) #4
Derek Schuff
On 2016/03/18 00:19:12, Derek Schuff wrote: > On 2016/03/17 22:04:40, Petr Hosek wrote: > > ...
4 years, 9 months ago (2016-03-18 00:20:24 UTC) #5
Petr Hosek
On 2016/03/18 00:20:24, Derek Schuff wrote: > On 2016/03/18 00:19:12, Derek Schuff wrote: > > ...
4 years, 9 months ago (2016-03-18 00:28:41 UTC) #6
Derek Schuff
On 2016/03/18 00:28:41, Petr Hosek wrote: > On 2016/03/18 00:20:24, Derek Schuff wrote: > > ...
4 years, 9 months ago (2016-03-18 00:40:35 UTC) #8
Petr Hosek
4 years, 9 months ago (2016-03-18 18:50:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d57a6f8b109145f0732906ff94c0380c0ee41953 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698