Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 181003010: Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} (Closed)

Created:
6 years, 9 months ago by Andrey Kraynov
Modified:
6 years, 9 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} This patch copies Source/web/WebFrameImpl.{cpp,h} into Source/web/TextFinder.{cpp,h} for decoupling WebFrameImpl and text finder. Another patch will complete decoupling. BUG=348972 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
A + Source/web/TextFinder.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/web/TextFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Andrey Kraynov
This is second try for the reverted issue https://codereview.chromium.org/119113003/ It was reverted in https://codereview.chromium.org/139383002/ Yoshi, ...
6 years, 9 months ago (2014-02-27 16:10:58 UTC) #1
yosin_UTC9
ACK +tkent@ for OWNERS review.
6 years, 9 months ago (2014-02-28 01:52:01 UTC) #2
tkent
> Another patch will complete decoupling. Are you sure you can work on it soon ...
6 years, 9 months ago (2014-02-28 01:55:57 UTC) #3
Andrey Kraynov
On 2014/02/28 01:55:57, tkent wrote: > > Another patch will complete decoupling. > > Are ...
6 years, 9 months ago (2014-03-05 16:37:11 UTC) #4
tkent
lgtm
6 years, 9 months ago (2014-03-07 01:48:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iceman@yandex-team.ru/181003010/1
6 years, 9 months ago (2014-03-07 01:48:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 05:20:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-07 05:20:52 UTC) #8
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-07 05:22:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iceman@yandex-team.ru/181003010/1
6 years, 9 months ago (2014-03-07 05:22:43 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 07:19:08 UTC) #11
Message was sent while issue was closed.
Change committed as 168712

Powered by Google App Engine
This is Rietveld 408576698