Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1809973002: X87: Assembler changes for enabling GrowHeap in Wasm (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Assembler changes for enabling GrowHeap in Wasm port e1a7c1e76c150713339bc5ba4ce84d7eb6a5420a (r34836) original commit message: - New RelocInfo mode WASM_MEMORY_REFERENCE as a marker for wasm code objects that need to be relocated on a heap change - RelocInfo mode recorded for immediates that use the memory buffer as base - Tests to verify address patching works BUG= Committed: https://crrev.com/b9b55bdc9ee3b784c12dfa3df1d70f600ef28d36 Cr-Commit-Position: refs/heads/master@{#34845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M src/x87/assembler-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 3 chunks +22 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -1 line 0 comments Download
A + test/cctest/test-run-wasm-relocation-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-17 08:05:00 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-17 08:18:18 UTC) #3
titzer
On 2016/03/17 08:18:18, Weiliang wrote: > lgtm lgtm
4 years, 9 months ago (2016-03-17 08:19:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809973002/1
4 years, 9 months ago (2016-03-17 08:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 08:39:41 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 08:40:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9b55bdc9ee3b784c12dfa3df1d70f600ef28d36
Cr-Commit-Position: refs/heads/master@{#34845}

Powered by Google App Engine
This is Rietveld 408576698