Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1809963002: [Editing][CodeHealth] Use w3c testharness in editing/seletion/move-by-* (Closed)

Created:
4 years, 9 months ago by yoichio
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][CodeHealth] Use w3c testharness in editing/seletion/move-by-* LayoutTests/editing/selection/ move-by-character-001.html move-by-character-002.html move-by-character-003.html move-by-character-004.html move-by-character-005.html move-by-character-6.html move-by-character-brute-force.html move-by-character-crash-test-textarea.html This CL also moves them to editing/selection/modify_move BUG= Committed: https://crrev.com/983f26ab52a1e2e0f6f6512dbb1810b41c34c169 Cr-Commit-Position: refs/heads/master@{#381677}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -3385 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-001.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-002.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-003.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-004.html View 1 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-005.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-6.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-brute-force.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-crash-test-textarea.html View 1 2 chunks +4 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-001.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-002.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-003.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-004.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-005.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-6.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-brute-force.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-brute-force-expected.txt View 1 chunk +0 lines, -1039 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-crash-test-textarea.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/move-by-character-crash-test-textarea-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-character-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-character-002-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-character-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-character-003-expected.txt View 1 chunk +0 lines, -187 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-character-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-character-004-expected.txt View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-character-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-character-005-expected.txt View 1 chunk +0 lines, -345 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-character-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-character-002-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-character-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-character-003-expected.txt View 1 chunk +0 lines, -187 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-character-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-character-004-expected.txt View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-character-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-character-005-expected.txt View 1 chunk +0 lines, -345 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-character-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-character-002-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-character-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-character-003-expected.txt View 1 chunk +0 lines, -187 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-character-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-character-004-expected.txt View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-character-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-character-005-expected.txt View 1 chunk +0 lines, -345 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
yoichio
4 years, 9 months ago (2016-03-17 07:43:17 UTC) #4
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-17 09:49:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809963002/20001
4 years, 9 months ago (2016-03-17 09:49:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 09:55:21 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 09:57:38 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/983f26ab52a1e2e0f6f6512dbb1810b41c34c169
Cr-Commit-Position: refs/heads/master@{#381677}

Powered by Google App Engine
This is Rietveld 408576698