Issue 1809943007: Remove unused FXDIB_PALETTE_ options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1809943007: Remove unused FXDIB_PALETTE_ options (Closed)

Created:
4 years, 9 months ago by Tom Sepez

Modified:
4 years, 9 months ago

Reviewers:
Oliver Chang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove unused FXDIB_PALETTE_ options The only one that is ever used is FXDIB_PALETTE_loc, so remove the option entirely. In turn, this allows deleting about 2KB of unused constant tables. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/69bbb0010cb83a7fa63d0901df6aef1de0ccfc0c

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -141 lines)			Patch
	M	core/fxge/dib/fx_dib_convert.cpp	View		5 chunks	+16 lines, -138 lines	0 comments	Download
	M	core/include/fxge/fx_dib.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Tom Sepez

4 years, 9 months ago (2016-03-21 18:40:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
69bbb0010cb83a7fa63d0901df6aef1de0ccfc0c (presubmit successful).