ui/views/bubble/bubble_frame_view.cc - Issue 1809933003: Port BubbleDelegate tests to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 1809933003: Port BubbleDelegate tests to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_frame_view.cc

diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc

index 0c1220cfe2be3e13ff30b7d770e83a4fe3eb26a9..3e63de96a220a0eac2563d6fa2a896b96b7f7cc3 100644

--- a/ui/views/bubble/bubble_frame_view.cc

+++ b/ui/views/bubble/bubble_frame_view.cc

@@ -141,7 +141,8 @@ int BubbleFrameView::NonClientHitTest(const gfx::Point& point) {

return HTCLOSE;

// Allow dialogs to show the system menu and be dragged.

msw 2016/03/17 17:28:26 nit: "allow non-bubble dialogs"?

Evan Stade 2016/03/17 22:41:34 I think the code is the best documentation in this

- if (GetWidget()->widget_delegate()->AsDialogDelegate()) {

+ if (GetWidget()->widget_delegate()->AsDialogDelegate() &&

+ !GetWidget()->widget_delegate()->AsBubbleDialogDelegate()) {

gfx::Rect sys_rect(0, 0, title_->x(), title_->y());

sys_rect.set_origin(gfx::Point(GetMirroredXForRect(sys_rect), 0));

if (sys_rect.Contains(point))