Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1809903002: Reland "Update mojo Decryptor interface to support reusing shared memory" (Closed)

Created:
4 years, 9 months ago by jrummell
Modified:
4 years, 9 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Update mojo Decryptor interface to support reusing shared memory" Now that VideoFrames are transported across mojo using shared memory, the original needs to stay around until the other side is no longer using it, after which the shared memory can be reused for a subsequent VideoFrame. BUG=510153 TEST=compiles on Windows Committed: https://crrev.com/97f461e96d8f6b733993d98b1df40cfe6f075063 Cr-Commit-Position: refs/heads/master@{#381800}

Patch Set 1 #

Patch Set 2 : add includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -4 lines) Patch
M media/mojo/common/mojo_shared_buffer_video_frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/interfaces/decryptor.mojom View 2 chunks +7 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_decryptor.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_decryptor.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_decryptor_service.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_decryptor_service.cc View 1 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jrummell
PTAL. PS#1 is the original, PS#2 is just adding #includes.
4 years, 9 months ago (2016-03-17 00:01:29 UTC) #3
xhwang
lgtm
4 years, 9 months ago (2016-03-17 21:17:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809903002/20001
4 years, 9 months ago (2016-03-17 21:22:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 21:29:00 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 21:31:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97f461e96d8f6b733993d98b1df40cfe6f075063
Cr-Commit-Position: refs/heads/master@{#381800}

Powered by Google App Engine
This is Rietveld 408576698