Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1809863003: [heap] Remove separate constant for newspace page allocatable size (Closed)

Created:
4 years, 9 months ago by Michael Lippautz
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove separate constant for newspace page allocatable size * New and old space pages have the same allocatable memory size * Enforce declaration order in NewSpacePage BUG=chromium:581412 LOG=N Committed: https://crrev.com/ef6585d8282d7437034de7a97695e2787ae29daa Cr-Commit-Position: refs/heads/master@{#34851}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -36 lines) Patch
M src/heap/spaces.h View 8 chunks +30 lines, -36 lines 2 comments Download

Messages

Total messages: 15 (8 generated)
Michael Lippautz
https://codereview.chromium.org/1809863003/diff/1/src/heap/spaces.h File src/heap/spaces.h (left): https://codereview.chromium.org/1809863003/diff/1/src/heap/spaces.h#oldcode2207 src/heap/spaces.h:2207: static const int kAreaSize = Page::kAllocatableMemory; Now available on ...
4 years, 9 months ago (2016-03-17 10:13:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809863003/1
4 years, 9 months ago (2016-03-17 10:28:23 UTC) #6
ulan
lgtm
4 years, 9 months ago (2016-03-17 10:59:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 11:00:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809863003/1
4 years, 9 months ago (2016-03-17 11:02:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 11:03:46 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 11:04:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef6585d8282d7437034de7a97695e2787ae29daa
Cr-Commit-Position: refs/heads/master@{#34851}

Powered by Google App Engine
This is Rietveld 408576698