Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: net/quic/quic_connection_test.cc

Issue 1809863002: Update some callers to use more direct ways of constructing IPAddress from well known literals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rch feedbak Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_chromium_client_session_test.cc ('k') | net/quic/test_tools/quic_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index 969fcf2f55bfa0fd7349ca2e86a4943c89d5243f..275cb4328e79ec8b05f021eaa1cc3b64a925a2a9 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -1027,9 +1027,7 @@ TEST_P(QuicConnectionTest, SelfAddressChangeAtClient) {
ProcessFramePacketWithAddresses(QuicFrame(&stream_frame), kSelfAddress,
kPeerAddress);
// Cause change in self_address.
- IPAddress address;
- ASSERT_TRUE(address.AssignFromIPLiteral("1.1.1.1"));
- IPEndPoint self_address(address, 123);
+ IPEndPoint self_address(IPAddress(1, 1, 1, 1), 123);
EXPECT_CALL(visitor_, OnStreamFrame(_));
ProcessFramePacketWithAddresses(QuicFrame(&stream_frame), self_address,
kPeerAddress);
@@ -1050,9 +1048,7 @@ TEST_P(QuicConnectionTest, SelfAddressChangeAtServer) {
ProcessFramePacketWithAddresses(QuicFrame(&stream_frame), kSelfAddress,
kPeerAddress);
// Cause change in self_address.
- IPAddress address;
- ASSERT_TRUE(address.AssignFromIPLiteral("1.1.1.1"));
- IPEndPoint self_address(address, 123);
+ IPEndPoint self_address(IPAddress(1, 1, 1, 1), 123);
EXPECT_CALL(visitor_, OnConnectionClosed(QUIC_ERROR_MIGRATING_ADDRESS, _));
ProcessFramePacketWithAddresses(QuicFrame(&stream_frame), self_address,
kPeerAddress);
« no previous file with comments | « net/quic/quic_chromium_client_session_test.cc ('k') | net/quic/test_tools/quic_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698