Update some callers to use more direct ways of constructing IPAddress from well known literals.

Update some callers to use more direct ways of constructing IPAddress from well known literals.

BUG=496258
Committed: https://crrev.com/36d84e54432fcdb48ac3903ad2ba4aa9d68ccca0
Cr-Commit-Position: refs/heads/master@{#381655}

[eroman, 2016-03-16 23:20:54]

Description was changed from

==========
Update some callers to more direct ways of constructing IPAddress from well
known literals.

Avoids doing string parsing + error for:

 "0.0.0.0"
 "::"
 "127.0.0.1"
 "::1"
==========

to

==========
Update some callers to use more direct ways of constructing IPAddress from well
known literals.

BUG=496258
==========

[eroman, 2016-03-16 23:52:01]

eroman@chromium.org changed reviewers:
+ rch@chromium.org

[eroman, 2016-03-16 23:52:02]

This is a continuation of the work that martijnc is doing around IPAddress
cleanups.

I had a few minutes to kill, so figured would change a few callers :)

[Ryan Hamilton, 2016-03-17 00:28:37]

lgtm

https://codereview.chromium.org/1809863002/diff/1/net/http/http_network_trans...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1809863002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:12915: auto peer_addr =
IPEndPoint(IPAddress::IPv4Localhost(), 443);
How about:

IPEndPoint peer_addr(IPAddress::IPv4Localhost(), 443);

(and below)

[eroman, 2016-03-17 01:01:20]

https://codereview.chromium.org/1809863002/diff/1/net/http/http_network_trans...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1809863002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:12915: auto peer_addr =
IPEndPoint(IPAddress::IPv4Localhost(), 443);
On 2016/03/17 00:28:37, Ryan Hamilton wrote:
> How about:
> 
> IPEndPoint peer_addr(IPAddress::IPv4Localhost(), 443);
> 
> (and below)

Done.

[eroman, 2016-03-17 01:02:08]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-03-17 01:02:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1809863002/#ps20001
(title: "rch feedbak")

[commit-bot: I haz the power, 2016-03-17 01:02:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809863002/20001

[commit-bot: I haz the power, 2016-03-17 03:23:18]

Description was changed from

==========
Update some callers to use more direct ways of constructing IPAddress from well
known literals.

BUG=496258
==========

to

==========
Update some callers to use more direct ways of constructing IPAddress from well
known literals.

BUG=496258
==========

[commit-bot: I haz the power, 2016-03-17 03:23:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-17 03:28:17]

Description was changed from

==========
Update some callers to use more direct ways of constructing IPAddress from well
known literals.

BUG=496258
==========

to

==========
Update some callers to use more direct ways of constructing IPAddress from well
known literals.

BUG=496258

Committed: https://crrev.com/36d84e54432fcdb48ac3903ad2ba4aa9d68ccca0
Cr-Commit-Position: refs/heads/master@{#381655}
==========

[commit-bot: I haz the power, 2016-03-17 03:28:18]

Patchset 2 (id:??) landed as
https://crrev.com/36d84e54432fcdb48ac3903ad2ba4aa9d68ccca0
Cr-Commit-Position: refs/heads/master@{#381655}