Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: content/renderer/media/video_track_recorder.cc

Issue 1809853002: MediaRecorder: Tune complexity settings for VP9 encoding (second go) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_track_recorder.cc
diff --git a/content/renderer/media/video_track_recorder.cc b/content/renderer/media/video_track_recorder.cc
index 9cbd91f38d2677bc4437837f1f26f74ca62a37bb..af389f8090f84de9d3747803505315af2e48523f 100644
--- a/content/renderer/media/video_track_recorder.cc
+++ b/content/renderer/media/video_track_recorder.cc
@@ -296,14 +296,6 @@ void VideoTrackRecorder::VpxEncoder::ConfigureEncoding(const gfx::Size& size) {
// DCHECK that the profile selected by default is I420 (magic number 0).
DCHECK_EQ(0u, codec_config_.g_profile);
-
- // Values of VP8E_SET_CPUUSED greater than 0 will increase encoder speed at
- // the expense of quality up to a maximum value of 16 for VP9, by tuning the
- // target time spent encoding the frame. Go from 12 to 6 depending on the
- // amount of cores available in the system.
- const int kCpuUsed = std::max(6, 13 - base::SysInfo::NumberOfProcessors());
- result = vpx_codec_control(encoder_.get(), VP8E_SET_CPUUSED, kCpuUsed);
- DLOG_IF(WARNING, VPX_CODEC_OK != result) << "VP8E_SET_CPUUSED failed";
} else {
// VP8 always produces frames instantaneously.
DCHECK_EQ(0u, codec_config_.g_lag_in_frames);
@@ -346,6 +338,17 @@ void VideoTrackRecorder::VpxEncoder::ConfigureEncoding(const gfx::Size& size) {
const vpx_codec_err_t ret = vpx_codec_enc_init(encoder_.get(), interface,
&codec_config_, kNoFlags);
DCHECK_EQ(VPX_CODEC_OK, ret);
+
+ if (use_vp9_) {
+ // Values of VP8E_SET_CPUUSED greater than 0 will increase encoder speed at
+ // the expense of quality up to a maximum value of 8 for VP9, by tuning the
+ // target time spent encoding the frame. Go from 8 to 5 (values for real
+ // time encoding) depending on the amount of cores available in the system.
+ const int kCpuUsed =
+ std::max(5, 8 - base::SysInfo::NumberOfProcessors() / 2);
+ result = vpx_codec_control(encoder_.get(), VP8E_SET_CPUUSED, kCpuUsed);
+ DLOG_IF(WARNING, VPX_CODEC_OK != result) << "VP8E_SET_CPUUSED failed";
+ }
}
bool VideoTrackRecorder::VpxEncoder::IsInitialized() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698