chrome/browser/ui/extensions/extension_action_view_controller.cc - Issue 1809813002: [Extensions] Show a "refresh" bubble when needed with click-to-script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_action_view_controller.cc

Issue 1809813002: [Extensions] Show a "refresh" bubble when needed with click-to-script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc ('k') | chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_action_view_controller.cc

diff --git a/chrome/browser/ui/extensions/extension_action_view_controller.cc b/chrome/browser/ui/extensions/extension_action_view_controller.cc

index bdbb532645e5ea77decfac2d16466af113dc8b38..4b9f1232f4695f0996985a706e74eb9b5072f337 100644

--- a/chrome/browser/ui/extensions/extension_action_view_controller.cc

+++ b/chrome/browser/ui/extensions/extension_action_view_controller.cc

@@ -216,7 +216,7 @@ bool ExtensionActionViewController::ExecuteAction(PopupShowAction show_action,

if (action_runner->RunAction(extension(), grant_tab_permissions) ==

ExtensionAction::ACTION_SHOW_POPUP) {

GURL popup_url = extension_action_->GetPopupUrl(

- SessionTabHelper::IdForTab(view_delegate_->GetCurrentWebContents()));

+ SessionTabHelper::IdForTab(web_contents));

return GetPreferredPopupViewController()

->TriggerPopupWithUrl(show_action, popup_url, grant_tab_permissions);

}