Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1809803003: Build the ANGLE dEQP tests on linux_optional_gpu_tests_rel (Closed)

Created:
4 years, 9 months ago by cwallez
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build the ANGLE dEQP tests on linux_optional_gpu_tests_rel Tryjobs on this bot try to run the angle_deqp_gles3_tests but it isn't found causing gn gen to fail. This fixes this issue by adding the correct gn flag to make ANGLE generate the dEQP targets. BUG=583702 Committed: https://crrev.com/9bbd96c417f30514448f827951237c31e507b8a6 Cr-Commit-Position: refs/heads/master@{#381580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Corentin Wallez
PTAL, this is blocking an ANGLE roll that contains an important revert, see https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_gpu_tests_rel/builds/61/steps/generate_build_files%20%28with%20patch%29/logs/stdio Ken, ...
4 years, 9 months ago (2016-03-16 21:35:19 UTC) #2
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-16 21:38:30 UTC) #3
Corentin Wallez
On 2016/03/16 at 21:38:30, dpranke wrote: > lgtm Thanks
4 years, 9 months ago (2016-03-16 21:39:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809803003/1
4 years, 9 months ago (2016-03-16 21:39:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 23:16:45 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9bbd96c417f30514448f827951237c31e507b8a6 Cr-Commit-Position: refs/heads/master@{#381580}
4 years, 9 months ago (2016-03-16 23:24:31 UTC) #9
Ken Russell (switch to Gerrit)
4 years, 9 months ago (2016-03-21 20:04:48 UTC) #10
Message was sent while issue was closed.
On 2016/03/16 21:35:19, Corentin Wallez wrote:
> PTAL, this is blocking an ANGLE roll that contains an important revert, see
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional...
> 
> Ken, do we also want to add the internal_gles2_conform flag here too? (If yes
> I'll do it in a follow up patch)

Sorry for the late reply. LGTM after the fact. Yes, the trybots and waterfall
bots should have similar configurations, so please do go ahead and add
internal_gles2_conform_tests to swarming_gpu_fyi_tests_gn_release_bot. Thanks.

Powered by Google App Engine
This is Rietveld 408576698