Move nacl_cmd_line to components/nacl/common.

chrome/nacl.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'include': [
     '../native_client/build/untrusted.gypi',
   ],
   'target_defaults': {
     'variables': {
@@ skipping 95 matching lines @@
               },
               'dependencies': [
                 '../native_client/src/trusted/service_runtime/service_runtime.gyp:sel_main_chrome64',
                 '../ppapi/ppapi_internal.gyp:ppapi_shared_win64',
                 '../ppapi/ppapi_internal.gyp:ppapi_ipc_win64',
               ],
               'export_dependent_settings': [
                 '../ppapi/ppapi_internal.gyp:ppapi_ipc_win64',
               ],
               'sources': [
-                'common/nacl_cmd_line.cc',
                 'common/nacl_debug_exception_handler_win.cc',
                 'common/nacl_messages.cc',
                 'common/nacl_types.cc',
                 'nacl/nacl_broker_listener.cc',
                 'nacl/nacl_broker_listener.h',
+                '../components/nacl/common/nacl_cmd_line.cc',

[Mark Seaborn, 2013/07/19 15:14:28]

This doesn't seem very clean.  Can you make this target depend on the
nacl_cmd_line library instead?  You'll probably need to add a
nacl_cmd_line_win64 library to build an x86-64 version.

               ],
               'include_dirs': [
                 '..',
               ],
               'defines': [
                 '<@(nacl_win64_defines)',
                 'COMPILE_CONTENT_STATICALLY',
               ],
               'configurations': {
                 'Common_Base': {
@@ skipping 77 matching lines @@
               'target_name': 'nacl_win64',
               'type': 'none',
               'sources': [],
             },
           ],
         }],
       ],
     }],
   ],
 }