content/browser/renderer_host/render_widget_host_view_android.cc - Issue 1809793002: Fix connection between BrowserAccessibilityManager and ContentViewCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 1809793002: Fix connection between BrowserAccessibilityManager and ContentViewCore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: InternalGetChild -> PlatformGetChild so we can walk into iframes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.h ('k') | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 65ed654f0342d396762742fb6e6c2c96cb3bd857..b2aa38c622656d9652ef1bf7b02c79d3ece66cf3 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -1611,15 +1611,12 @@ void RenderWidgetHostViewAndroid::OnSetNeedsFlushInput() {

BrowserAccessibilityManager*

RenderWidgetHostViewAndroid::CreateBrowserAccessibilityManager(

- BrowserAccessibilityDelegate* delegate) {

- base::android::ScopedJavaLocalRef<jobject> obj;

- if (host_ &&

- host_->GetRootBrowserAccessibilityManager() &&

- content_view_core_) {

- obj = content_view_core_->GetJavaObject();

- }

+ BrowserAccessibilityDelegate* delegate, bool for_root_frame) {

+ base::android::ScopedJavaLocalRef<jobject> content_view_core_obj;

+ if (for_root_frame && host_ && content_view_core_)

+ content_view_core_obj = content_view_core_->GetJavaObject();

return new BrowserAccessibilityManagerAndroid(

- obj,

+ content_view_core_obj,

BrowserAccessibilityManagerAndroid::GetEmptyDocument(),

delegate);

}