content/browser/frame_host/render_frame_host_impl.cc - Issue 1809793002: Fix connection between BrowserAccessibilityManager and ContentViewCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1809793002: Fix connection between BrowserAccessibilityManager and ContentViewCore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: InternalGetChild -> PlatformGetChild so we can walk into iframes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index c945e389582606988424d09c98eee87703f3fd64..27e4b5994281e343db3af7dbad36aed8967af832 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -2420,8 +2420,9 @@ BrowserAccessibilityManager*

if (view &&

!browser_accessibility_manager_ &&

!no_create_browser_accessibility_manager_for_testing_) {

+ bool is_root_frame = !frame_tree_node()->parent();

browser_accessibility_manager_.reset(

- view->CreateBrowserAccessibilityManager(this));

+ view->CreateBrowserAccessibilityManager(this, is_root_frame));

if (browser_accessibility_manager_)

UMA_HISTOGRAM_COUNTS("Accessibility.FrameEnabledCount", 1);

else