Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1809783003: Run Sizes on Windows perf builders (Closed)

Created:
4 years, 9 months ago by hans
Modified:
4 years, 9 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Run Sizes on Windows perf builders I want to be able to track down Windows size regressions with the win perf trybots. BUG=457078 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+717 lines, -0 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_perf.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_Builder.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_8_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_fyi_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_perf_bisect_builder.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_x64_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_10_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_10_perf_cq.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_bisect_builder.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_zen_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64ati_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64intel_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64nvidia_perf_bisect.json View 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
hans
I was able to run Clang builds on the win_perf_bisect_builder: https://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect_builder/builds/13489 That would be very ...
4 years, 9 months ago (2016-03-17 14:46:52 UTC) #2
eakuefner-google (do not use)
+dtu
4 years, 9 months ago (2016-03-17 14:57:43 UTC) #4
dtu
Windows only? Should it apply to all platforms?
4 years, 9 months ago (2016-03-17 22:07:44 UTC) #5
hans
On 2016/03/17 22:07:44, dtu wrote: > Windows only? Should it apply to all platforms? Don't ...
4 years, 9 months ago (2016-03-17 22:36:54 UTC) #6
dtu
lgtm
4 years, 9 months ago (2016-03-17 23:03:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809783003/1
4 years, 9 months ago (2016-03-18 07:19:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3200)
4 years, 9 months ago (2016-03-18 07:25:27 UTC) #11
hans
+robertocn, +prasadv Please take an OWNERS look.
4 years, 9 months ago (2016-03-18 07:29:38 UTC) #13
eakuefner
Dave, maybe you should extend your per-file ownership to include the tryserver stuff, or at ...
4 years, 9 months ago (2016-03-18 17:17:53 UTC) #14
prasadv
lgtm
4 years, 9 months ago (2016-03-18 17:23:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809783003/1
4 years, 9 months ago (2016-03-18 17:39:12 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299385
4 years, 9 months ago (2016-03-18 17:42:15 UTC) #19
agable
4 years, 9 months ago (2016-03-22 17:11:22 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1827443002/ by agable@chromium.org.

The reason for reverting is: New sizes step always fails:
https://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/5630...

See https://bugs.chromium.org/p/chromium/issues/detail?id=596145#c7 for
additional details.

Powered by Google App Engine
This is Rietveld 408576698