DevTools: split platformFontsWidget.css out of elementsPanel.css

DevTools: split platformFontsWidget.css out of elementsPanel.css

BUG=none
R=dgozman, pfeldman

Committed: https://crrev.com/32c75aadd1acd3e7c6364750cbf1797ca409ab2f
Cr-Commit-Position: refs/heads/master@{#381551}

[lushnikov, 2016-03-16 18:32:59]

ptal

[lushnikov, 2016-03-16 18:33:17]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 18:33:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809773002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809773002/1

[dgozman, 2016-03-16 18:59:07]

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js
(right):

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js:38:
WebInspector.ThrottledWidget.call(this);
Can we make it a web component as well (pass true here)?

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js:39:
this.element.classList.add("platform-fonts");
Perhaps, you don't need this class anymore and could use :host instead?

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js:48:
this.registerRequiredCSS("elements/platformFontsWidget.css");
nit: usually do that in a second line of constructor.

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/platformFontsWidget.css
(right):

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/platformFontsWidget.css:20:
.platform-fonts .sidebar-separator {
Remove all .platform-fonts prefixes except maybe this one?

[lushnikov, 2016-03-16 20:18:20]

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js
(right):

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js:38:
WebInspector.ThrottledWidget.call(this);
On 2016/03/16 18:59:07, dgozman wrote:
> Can we make it a web component as well (pass true here)?

Done.

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js:39:
this.element.classList.add("platform-fonts");
On 2016/03/16 18:59:07, dgozman wrote:
> Perhaps, you don't need this class anymore and could use :host instead?

Done.

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js:48:
this.registerRequiredCSS("elements/platformFontsWidget.css");
On 2016/03/16 18:59:07, dgozman wrote:
> nit: usually do that in a second line of constructor.

Done.

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/platformFontsWidget.css
(right):

https://codereview.chromium.org/1809773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/platformFontsWidget.css:20:
.platform-fonts .sidebar-separator {
On 2016/03/16 18:59:07, dgozman wrote:
> Remove all .platform-fonts prefixes except maybe this one?

Removed all of them. Merged sidebar-separator styles in this rule as well - they
shouldn't be shared.

[lushnikov, 2016-03-16 20:18:27]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 20:19:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809773002/20001

[lushnikov, 2016-03-16 20:50:31]

please, take another look.

[dgozman, 2016-03-16 21:12:29]

lgtm

[lushnikov, 2016-03-16 21:16:08]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-03-16 21:16:08]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-03-16 21:16:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809773002/20001

[commit-bot: I haz the power, 2016-03-16 21:35:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-16 21:39:12]

Description was changed from

==========
DevTools: split platformFontsWidget.css out of elementsPanel.css

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: split platformFontsWidget.css out of elementsPanel.css

BUG=none
R=dgozman, pfeldman

Committed: https://crrev.com/32c75aadd1acd3e7c6364750cbf1797ca409ab2f
Cr-Commit-Position: refs/heads/master@{#381551}
==========

[commit-bot: I haz the power, 2016-03-16 21:39:13]

Patchset 2 (id:??) landed as
https://crrev.com/32c75aadd1acd3e7c6364750cbf1797ca409ab2f
Cr-Commit-Position: refs/heads/master@{#381551}