Respect SVG fragment identifiers in <img> src attribute

Respect SVG fragment identifiers in <img> src attribute https://bugs.webkit.org/show_bug.cgi?id=129387

When providing an SVG image for a given renderer, check that the URL used to load
that image is taken into account in case it featured a fragment identifier, ensuring
that the CSS :target pseudo-class is correctly handled for SVG resources. This patch
is specific to <img> elements, specific support will also need to be added for various
CSS properties that support SVG images.

Based on the webkit patch by Antoine Quint <graouts@webkit.org>;.

BUG=369513, 156584
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173213

[krit, 2014-02-27 16:16:14]

On 2014/02/27 16:11:11, Erik Dahlström wrote:

As commented on the original bug. I think we should investigate first if we can
find a common solution. Otherwise we have a hacky solution that just gets
extended instead of fixing it properly.

[Erik Dahlström (inactive), 2014-02-27 16:23:56]

On 2014/02/27 16:16:14, krit wrote:
> On 2014/02/27 16:11:11, Erik Dahlström wrote:
> 
> As commented on the original bug. I think we should investigate first if we
can
> find a common solution. Otherwise we have a hacky solution that just gets
> extended instead of fixing it properly.

A common solution doesn't exclude this as a first step, the functionality (for
<img> elements) would remain the same even if we find a more generic way to
handle this.

[fs, 2014-05-02 15:19:54]

On 2014/02/27 16:23:56, Erik Dahlström wrote:
> On 2014/02/27 16:16:14, krit wrote:
> > On 2014/02/27 16:11:11, Erik Dahlström wrote:
> > 
> > As commented on the original bug. I think we should investigate first if we
> can
> > find a common solution. Otherwise we have a hacky solution that just gets
> > extended instead of fixing it properly.
> 
> A common solution doesn't exclude this as a first step, the functionality (for
> <img> elements) would remain the same even if we find a more generic way to
> handle this.

Maybe file a bug for that then? Otherwise this LGTM.

[fs, 2014-05-02 15:22:30]

...with a nit/question.

https://codereview.chromium.org/180973005/diff/60001/Source/core/svg/graphics...
File Source/core/svg/graphics/SVGImageForContainer.cpp (right):

https://codereview.chromium.org/180973005/diff/60001/Source/core/svg/graphics...
Source/core/svg/graphics/SVGImageForContainer.cpp:23: #include
"core/frame/FrameView.h"
Nit: Not quite sure why this would be needed now.

[Erik Dahlström (inactive), 2014-05-02 15:41:13]

On 2014/05/02 15:19:54, fs wrote:
> On 2014/02/27 16:23:56, Erik Dahlström wrote:
> > On 2014/02/27 16:16:14, krit wrote:
> > > On 2014/02/27 16:11:11, Erik Dahlström wrote:
> > > 
> > > As commented on the original bug. I think we should investigate first if
we
> > can
> > > find a common solution. Otherwise we have a hacky solution that just gets
> > > extended instead of fixing it properly.
> > 
> > A common solution doesn't exclude this as a first step, the functionality
(for
> > <img> elements) would remain the same even if we find a more generic way to
> > handle this.
> 
> Maybe file a bug for that then? Otherwise this LGTM.

That's http://crbug.com/128055 and we have also have http://crbug.com/156584 for
:target which doesn't work yet AFAICT.

[Erik Dahlström (inactive), 2014-05-02 15:47:11]

The CQ bit was checked by ed@opera.com

[commit-bot: I haz the power, 2014-05-02 15:47:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/180973005/80001

[commit-bot: I haz the power, 2014-05-02 18:45:26]

Change committed as 173213