Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 1809723002: Remove optional --commit-author argument from auto-rebaseline script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index ce39fe5a5a250a804e2941419a0c34998d0e9f04..d7f2a01488872004258fc356cd4b70cbf8460b47 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -687,8 +687,6 @@ class AutoRebaseline(AbstractParallelRebaselineCommand):
# FIXME: Remove this option.
self.results_directory_option,
optparse.make_option("--auth-refresh-token-json", help="Rietveld auth refresh JSON token."),
- optparse.make_option("--commit-author",
- help='Optionally specify an explicit author for local commit. Format as "Name <email>".'),
optparse.make_option("--dry-run", action='store_true', default=False,
help='Run without creating a temporary branch, committing locally, or uploading/landing '
'changes to the remote repository.')
@@ -903,8 +901,7 @@ class AutoRebaseline(AbstractParallelRebaselineCommand):
return
tool.scm().commit_locally_with_message(
- self.commit_message(author, revision, commit, bugs),
- author=options.commit_author)
+ self.commit_message(author, revision, commit, bugs))
# FIXME: It would be nice if we could dcommit the patch without uploading, but still
# go through all the precommit hooks. For rebaselines with lots of files, uploading

Powered by Google App Engine
This is Rietveld 408576698