Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1809723002: Remove optional --commit-author argument from auto-rebaseline script. (Closed)

Created:
4 years, 9 months ago by wkorman
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, agable
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove optional --commit-author argument from auto-rebaseline script. The bot now uses 'git config' to explicitly set the intended author/committer user name and email before running the script, rather than routing through the rebaseline script itself. BUG=594817, 589140 Committed: https://crrev.com/549cbbcd3e66201f260b1e1050645b14601c4189 Cr-Commit-Position: refs/heads/master@{#381776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
wkorman
4 years, 9 months ago (2016-03-16 17:27:35 UTC) #2
wkorman
4 years, 9 months ago (2016-03-17 17:27:46 UTC) #4
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-17 17:29:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809723002/1
4 years, 9 months ago (2016-03-17 17:35:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 19:48:13 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 19:49:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/549cbbcd3e66201f260b1e1050645b14601c4189
Cr-Commit-Position: refs/heads/master@{#381776}

Powered by Google App Engine
This is Rietveld 408576698