Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tests/language/no_such_method_dispatcher_test.dart

Issue 18097004: Support fast noSuchMethod dispatch for any number of arguments. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stack_frame_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/no_such_method_dispatcher_test.dart
===================================================================
--- tests/language/no_such_method_dispatcher_test.dart (revision 24510)
+++ tests/language/no_such_method_dispatcher_test.dart (working copy)
@@ -16,6 +16,35 @@
class B extends A { }
+
+call_bar(x) => x.bar();
+
+testMessage() {
+ try {
+ call_bar(5);
+ } catch (e) {
+ Expect.isTrue(e.toString().indexOf("method not found") != -1);
ahe 2013/07/20 17:24:27 I'm working on improving dart2js' handling of NoSu
+ }
+}
+
+class C {
+ C(this.pos, this.named, this.posArgs, this.namedArgs);
+ var pos, named;
+ noSuchMethod(m) {
+ Expect.equals(pos, m.positionalArguments.length);
+ Expect.equals(named, m.namedArguments.length);
+ for (var i = 0; i < posArgs.length; ++i) {
+ Expect.equals(posArgs[i], m.positionalArguments[i]);
+ }
+ for (var k in namedArgs.keys) {
+ Expect.equals(namedArgs[k], m.namedArguments[new Symbol(k)]);
+ }
+ return 123;
+ }
+ List posArgs;
+ Map namedArgs;
+}
+
main() {
var a = new A();
for (var i = 0; i < 100; ++i) Expect.equals(123, a.foo());
@@ -28,5 +57,21 @@
Expect.equals(123, b.bar());
Expect.equals(2, b.bar(1));
}
+
+ for (var i = 0; i < 100; ++i) {
+ Expect.equals(123, b.bar(1,2,3));
+ Expect.equals(123, b.bar(1,2,foo:3));
+ }
+
+ // Test named and positional arguments.
+ var c = new C(1, 2, [100], {"n1":101, "n2":102});
+ for (var i = 0; i < 100; ++i) {
+ Expect.equals(123, c.bar(100, n1:101, n2:102));
+ Expect.equals(123, c.bar(100, n2:102, n1:101));
+ }
+
+ // Test NoSuchMethodError message.
+ for (var i = 0; i < 100; i++) testMessage();
+
}
« no previous file with comments | « runtime/vm/stack_frame_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698