Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1809683002: Reland: Check for url changes to flip state for showing title only (Closed)

Created:
4 years, 9 months ago by Yusuf
Modified:
4 years, 9 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Check for url changes to flip state for showing title only We used to only keep a boolean for a first load, but that seems to be very fragile since onNavigatedToDifferentPage also gets called in refrestSelectedTab. This caches the initial url and only flips state when there is a change from the url BUG=590326 Committed: https://crrev.com/7b573e416404e90e942d3b63efb597702faa2775 Cr-Commit-Position: refs/heads/master@{#381515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yusuf
4 years, 9 months ago (2016-03-16 16:56:06 UTC) #2
Ian Wen
lgtm
4 years, 9 months ago (2016-03-16 18:01:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809683002/1
4 years, 9 months ago (2016-03-16 18:04:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:04:56 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:06:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b573e416404e90e942d3b63efb597702faa2775
Cr-Commit-Position: refs/heads/master@{#381515}

Powered by Google App Engine
This is Rietveld 408576698