Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1809663002: Propogate SkBudgeted for NewFromDeferredTextureImageData (Closed)

Created:
4 years, 9 months ago by ericrk
Modified:
4 years, 9 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Propogate SkBudgeted for NewFromDeferredTextureImageData The budgeted flag was not propogated from NewFromDeferredTextureImageData to MakeTextureFromPixmap, resulting in the created textures always being budgeted, even when SkBudgeted::kNo was passed in. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1809663002 Committed: https://skia.googlesource.com/skia/+/8bea8905e406fc1d15ef5a8294a735f3d33fb2d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/gpu/SkGr.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ericrk
I noticed that my GPU Image Decode manager was causing significant cache pressure in Skia ...
4 years, 9 months ago (2016-03-16 16:13:07 UTC) #3
bsalomon
Ah, yes. Sorry I missed that. lgtm
4 years, 9 months ago (2016-03-18 02:07:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809663002/1
4 years, 9 months ago (2016-03-18 18:32:20 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 18:52:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8bea8905e406fc1d15ef5a8294a735f3d33fb2d0

Powered by Google App Engine
This is Rietveld 408576698