Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1809653002: Remove filtering reference builds in gclient file (Closed)

Created:
4 years, 9 months ago by magjed_chromium
Modified:
4 years, 8 months ago
CC:
aiolos0
Base URL:
https://chromium.googlesource.com/libyuv/libyuv.git@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Remove filtering reference builds in gclient file The reference builds no longer exists, so we can remove them from the .gclient config. R=aiolos@chromium.org, torbjorng@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/5065743a110bb2edd79e71de5df71a31f3009a96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chromium/.gclient View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
magjed_chromium
Please take a look.
4 years, 9 months ago (2016-03-16 15:45:21 UTC) #3
torbjorng
lgtm
4 years, 9 months ago (2016-03-16 15:46:30 UTC) #4
aiolos (Not reviewing)
lgtm
4 years, 9 months ago (2016-03-16 19:37:51 UTC) #6
fbarchard1
lgtm
4 years, 9 months ago (2016-03-23 22:16:21 UTC) #7
aiolos (Not reviewing)
Feel free to submit.
4 years, 9 months ago (2016-03-24 00:26:16 UTC) #8
kjellander_chromium
On 2016/03/24 00:26:16, aiolos wrote: > Feel free to submit. Please change the CL description ...
4 years, 8 months ago (2016-03-31 11:05:22 UTC) #10
magjed_chromium
Committed patchset #1 (id:1) manually as 5065743a110bb2edd79e71de5df71a31f3009a96 (presubmit successful).
4 years, 8 months ago (2016-03-31 11:18:39 UTC) #12
magjed_chromium
4 years, 8 months ago (2016-03-31 11:25:26 UTC) #14
Message was sent while issue was closed.
On 2016/03/31 11:05:22, kjellander (chromium) wrote:
> On 2016/03/24 00:26:16, aiolos wrote:
> > Feel free to submit.
> 
> Please change the CL description to make it clear that you remove the
> _filtering_ of the reference builds.
> I guess you do this because they no longer exists in this location?

Yes, they no longer exists. I didn't see your message before I landed the CL
unfortunately, but I updated the CL description now.

Powered by Google App Engine
This is Rietveld 408576698