third_party/WebKit/Source/core/layout/LayoutTableRow.cpp - Issue 1809643008: Adding or changing any of box-shadow, outline, or border-image-outset does not need a layout..

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 1809643008: Adding or changing any of box-shadow, outline, or border-image-outset does not need a layout.. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutTableRow.h ('K') | « third_party/WebKit/Source/core/layout/LayoutTableRow.h ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.h » ('j') | third_party/WebKit/Source/core/style/StyleDifference.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

index 149d4f72a71cfbfa6ce1f74a5ab398334977cb0d..f6aeb2fbf065e92a2552b7213482224c8fa3d44d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

@@ -237,9 +237,18 @@ LayoutTableRow* LayoutTableRow::createAnonymousWithParent(const LayoutObject* pa

return newRow;

}

+void LayoutTableRow::recomputeOverflow()

+ clearAllOverflows();

+ addVisualEffectOverflow();

+ for (LayoutTableCell* cell = firstCell(); cell; cell = cell->nextCell())

+ addOverflowFromCell(cell);

void LayoutTableRow::addOverflowFromCell(const LayoutTableCell* cell)

{

// Non-row-spanning-cells don't create overflow (they are fully contained within this row).

+ // TODO(rhogan, wangxianzhu): This seems incorrect because cell may have visual effect overflow that should be included in this row.

Xianzhu 2016/04/15 04:59:16 Can you file a bug for this? Then you can use TODO

rhogan 2016/04/15 19:34:32 Done.

if (cell->rowSpan() == 1)

return;