content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h - Issue 1809623002: Replace all uses of webrtc::VideoRendererInterface by rtc::VideoSinkInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h

Issue 1809623002: Replace all uses of webrtc::VideoRendererInterface by rtc::VideoSinkInterface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nit. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc ('k') | content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h

diff --git a/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h b/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h

index a4ef6d162c8498a244064fc00e8dd0fb881a7deb..a6323a9fdb0cb0ae4e4a9b105e53e6cffc5c0f27 100644

--- a/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h

+++ b/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h

@@ -72,8 +72,9 @@ class MockWebRtcVideoTrack : public webrtc::VideoTrackInterface {

public:

MockWebRtcVideoTrack(const std::string& id,

webrtc::VideoTrackSourceInterface* source);

- void AddRenderer(webrtc::VideoRendererInterface* renderer) override;

- void RemoveRenderer(webrtc::VideoRendererInterface* renderer) override;

+ void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,

+ const rtc::VideoSinkWants& wants) override;

+ void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override;

std::string kind() const override;

std::string id() const override;

bool enabled() const override;

@@ -93,7 +94,7 @@ class MockWebRtcVideoTrack : public webrtc::VideoTrackInterface {

TrackState state_;

scoped_refptr<webrtc::VideoTrackSourceInterface> source_;

ObserverSet observers_;

- webrtc::VideoRendererInterface* renderer_;

+ rtc::VideoSinkInterface<cricket::VideoFrame>* sink_;

};

class MockMediaStream : public webrtc::MediaStreamInterface {