content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc - Issue 1809623002: Replace all uses of webrtc::VideoRendererInterface by rtc::VideoSinkInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

Issue 1809623002: Replace all uses of webrtc::VideoRendererInterface by rtc::VideoSinkInterface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nit. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/media_stream_remote_video_source.cc ('k') | content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

diff --git a/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc b/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

index 2233bba27e29c9a9bdf89b6ae742c9a02c418c6a..696decd456af0c71953da73f6365bdd837cb6b46 100644

--- a/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

+++ b/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

@@ -32,7 +32,7 @@ class MediaStreamRemoteVideoSourceUnderTest

explicit MediaStreamRemoteVideoSourceUnderTest(

scoped_ptr<TrackObserver> observer)

: MediaStreamRemoteVideoSource(std::move(observer)) {}

- using MediaStreamRemoteVideoSource::RenderInterfaceForTest;

+ using MediaStreamRemoteVideoSource::SinkInterfaceForTest;

};

class MediaStreamRemoteVideoSourceTest

@@ -131,7 +131,7 @@ TEST_F(MediaStreamRemoteVideoSourceTest, StartTrack) {

RunClosure(quit_closure));

cricket::WebRtcVideoFrame webrtc_frame;

webrtc_frame.InitToBlack(320, 240, 1);

- source()->RenderInterfaceForTest()->RenderFrame(&webrtc_frame);

+ source()->SinkInterfaceForTest()->OnFrame(webrtc_frame);

run_loop.Run();

EXPECT_EQ(1, sink.number_of_frames());