Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1809623002: Replace all uses of webrtc::VideoRendererInterface by rtc::VideoSinkInterface. (Closed)

Created:
4 years, 9 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace all uses of webrtc::VideoRendererInterface by rtc::VideoSinkInterface. BUG=webrtc:5426 Committed: https://crrev.com/c69f2f97d6b9e4cf13d8fad44fad45eded6a119f Cr-Commit-Position: refs/heads/master@{#381678}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address nit. #

Messages

Total messages: 16 (7 generated)
nisse-chromium (ooo August 14)
This is a simple-minded replacement of webrtc::VideoRendererInterface.
4 years, 9 months ago (2016-03-16 12:03:20 UTC) #2
Sergey Ulanov
lgtm https://codereview.chromium.org/1809623002/diff/1/remoting/protocol/webrtc_video_renderer_adapter.h File remoting/protocol/webrtc_video_renderer_adapter.h (right): https://codereview.chromium.org/1809623002/diff/1/remoting/protocol/webrtc_video_renderer_adapter.h#newcode23 remoting/protocol/webrtc_video_renderer_adapter.h:23: } add "// namespace cricket" for consistency
4 years, 9 months ago (2016-03-16 19:17:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809623002/1
4 years, 9 months ago (2016-03-17 07:45:34 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 08:45:05 UTC) #8
perkj_chrome
lgtm
4 years, 9 months ago (2016-03-17 08:47:26 UTC) #9
perkj_chrome
On 2016/03/17 08:47:26, perkj_chrome wrote: > lgtm dont forget Sergye's nit.
4 years, 9 months ago (2016-03-17 08:47:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809623002/20001
4 years, 9 months ago (2016-03-17 08:53:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 09:58:07 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 09:59:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c69f2f97d6b9e4cf13d8fad44fad45eded6a119f
Cr-Commit-Position: refs/heads/master@{#381678}

Powered by Google App Engine
This is Rietveld 408576698