Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1809603003: Separate mouse transition events from pointerevent (Closed)

Created:
4 years, 9 months ago by Navid Zolghadr
Modified:
4 years, 8 months ago
Reviewers:
mustaq, Rick Byers
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, dtapuska+blinkwatch_chromium.org, darktears, blink-reviews, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate mouse transition events from pointerevent This CL will separate sending mouse transition events from pointer events (with type=mouse) transitions as they might belong to different node anyway. This allows us more separation of mouse event and pointer events. BUG=587955 Committed: https://crrev.com/fd312312165253f96bd75c19716444805fadf087 Cr-Commit-Position: refs/heads/master@{#383787}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding/Fixing Tests #

Patch Set 3 : Add the missing test result #

Total comments: 19

Patch Set 4 : Appling the comments and adding extra test #

Total comments: 13

Patch Set 5 : Applying the comments #

Total comments: 4

Patch Set 6 : Better comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1775 lines, -1159 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html View 1 4 chunks +20 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt View 1 2 2 chunks +325 lines, -325 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-expected.txt View 1 14 chunks +42 lines, -42 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events.html View 1 2 3 4 1 chunk +112 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt View 1 2 3 4 1 chunk +437 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt View 1 1 chunk +600 lines, -600 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-preventdefault-expected.txt View 1 16 chunks +64 lines, -64 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-transition-events-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 3 9 chunks +20 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.h View 1 2 3 4 5 3 chunks +35 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 2 3 4 19 chunks +113 lines, -74 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
Navid Zolghadr
This is a tentative change to address the issue of the difference between mouse transition ...
4 years, 9 months ago (2016-03-16 16:39:28 UTC) #2
mustaq
Here are my quick comments: since we will have to fire mousedown etc after pointerdown ...
4 years, 9 months ago (2016-03-16 19:06:37 UTC) #3
Navid Zolghadr
https://codereview.chromium.org/1809603003/diff/1/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-transition-events-expected.txt File third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-transition-events-expected.txt (right): https://codereview.chromium.org/1809603003/diff/1/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-transition-events-expected.txt#newcode6 third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-transition-events-expected.txt:6: green received mouseover, at phase=target On 2016/03/16 19:06:37, mustaq ...
4 years, 9 months ago (2016-03-16 19:39:33 UTC) #4
Navid Zolghadr
ptal. I applied the comment about ordering of mouse transition events and pointer transition events ...
4 years, 9 months ago (2016-03-18 16:10:38 UTC) #5
mustaq
https://codereview.chromium.org/1809603003/diff/40001/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt File third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt (right): https://codereview.chromium.org/1809603003/diff/40001/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt#newcode30 third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt:30: green received pointermove The enter/leave and over/out pairing in-between ...
4 years, 9 months ago (2016-03-22 15:28:43 UTC) #6
Navid Zolghadr
ptal. I applied the comments and fix the test output as well as adding some ...
4 years, 9 months ago (2016-03-22 18:00:24 UTC) #7
mustaq
LGTM, the transition events look perfect now. A couple of nits around readability... https://codereview.chromium.org/1809603003/diff/40001/third_party/WebKit/Source/core/input/PointerEventManager.cpp File ...
4 years, 9 months ago (2016-03-23 18:49:07 UTC) #8
Navid Zolghadr
ptal https://codereview.chromium.org/1809603003/diff/60001/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt File third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt (right): https://codereview.chromium.org/1809603003/diff/60001/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt#newcode6 third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-capture-transition-events-expected.txt:6: ==== 'none' is capturing and then 'blue' will ...
4 years, 9 months ago (2016-03-23 19:47:48 UTC) #9
mustaq
Still lgtm. https://codereview.chromium.org/1809603003/diff/60001/third_party/WebKit/Source/core/input/PointerEventManager.h File third_party/WebKit/Source/core/input/PointerEventManager.h (right): https://codereview.chromium.org/1809603003/diff/60001/third_party/WebKit/Source/core/input/PointerEventManager.h#newcode47 third_party/WebKit/Source/core/input/PointerEventManager.h:47: // only when the transition is beyond ...
4 years, 9 months ago (2016-03-23 20:02:33 UTC) #10
Rick Byers
LGTM with nit There are some active debates about the desired behavior here (https://github.com/w3c/pointerevents/issues/35), but ...
4 years, 8 months ago (2016-03-29 16:37:14 UTC) #11
Navid Zolghadr
https://codereview.chromium.org/1809603003/diff/80001/third_party/WebKit/Source/core/input/EventHandler.h File third_party/WebKit/Source/core/input/EventHandler.h (right): https://codereview.chromium.org/1809603003/diff/80001/third_party/WebKit/Source/core/input/EventHandler.h#newcode314 third_party/WebKit/Source/core/input/EventHandler.h:314: void updateMouseEventTargetNodeAndSendEvents(Node*, const PlatformMouseEvent&, bool = false); On 2016/03/29 ...
4 years, 8 months ago (2016-03-29 17:44:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809603003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809603003/100001
4 years, 8 months ago (2016-03-29 18:58:47 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-03-29 19:04:30 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 19:05:38 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/fd312312165253f96bd75c19716444805fadf087
Cr-Commit-Position: refs/heads/master@{#383787}

Powered by Google App Engine
This is Rietveld 408576698