Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1809593002:
[SPv2] Disables paint layer culling (Closed)
|
Created:
4 years, 9 months ago by trchen Modified:
4 years, 8 months ago Reviewers:
chrishtr CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[SPv2] Disables paint layer culling
In SPv2, the cull rect generated by the layer clipper does not match the space
we paint in. We decided to punt it until the Web Page Geometries API is
implemented, so we can easily derive the cull rect from tree builder.
BUG=593596
Committed: https://crrev.com/d4136c471aa2c38eb335f684b031088f490dfb1a
Cr-Commit-Position: refs/heads/master@{#389026}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : fix test issue #Patch Set 4 : +mac test expectation #
Messages
Total messages: 33 (15 generated)
trchen@chromium.org changed reviewers: + chrishtr@chromium.org
As we discussed on Monday. Let's disable culling for SPv2 temporarily.
The CQ bit was checked by trchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809593002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The unit test failure was due to bogus clip display items with infinite rect. The latest CL simply omitted clip display items for SPv2, which are useless anyway.
The CQ bit was checked by trchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809593002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2016/04/20 at 04:16:52, trchen wrote: > The unit test failure was due to bogus clip display items with infinite rect. The latest CL simply omitted clip display items for SPv2, which are useless anyway. It looks like the infinite rects are still there in the latest patchset. ?
On 2016/04/20 16:40:48, chrishtr wrote: > On 2016/04/20 at 04:16:52, trchen wrote: > > The unit test failure was due to bogus clip display items with infinite rect. > The latest CL simply omitted clip display items for SPv2, which are useless > anyway. > > It looks like the infinite rects are still there in the latest patchset. ? Yes, we still need to set the layer clip rects to infinite rect despite we don't create clip display items, because they are still used as cull rect. In PS3 I omitted the clip display items because overriding the layer clip rects can ended up emitting extra (bogus) clip display items. I felt it silly to rebaseline unit tests just for that. Sorry for delaying this straightforward CL for so long. I always forgot to bring my Macbook to office then forgot to look at the failures after getting home. :/
The CQ bit was checked by chrishtr@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809593002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by trchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809593002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809593002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #4 (id:60001) has been deleted
The CQ bit was checked by trchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809593002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809593002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by trchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org Link to the patchset: https://codereview.chromium.org/1809593002/#ps80001 (title: "+mac test expectation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809593002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809593002/80001
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [SPv2] Disables paint layer culling In SPv2, the cull rect generated by the layer clipper does not match the space we paint in. We decided to punt it until the Web Page Geometries API is implemented, so we can easily derive the cull rect from tree builder. BUG=593596 ========== to ========== [SPv2] Disables paint layer culling In SPv2, the cull rect generated by the layer clipper does not match the space we paint in. We decided to punt it until the Web Page Geometries API is implemented, so we can easily derive the cull rect from tree builder. BUG=593596 Committed: https://crrev.com/d4136c471aa2c38eb335f684b031088f490dfb1a Cr-Commit-Position: refs/heads/master@{#389026} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d4136c471aa2c38eb335f684b031088f490dfb1a Cr-Commit-Position: refs/heads/master@{#389026} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
