Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1809543002:
[DevTools] Add 200ms timeout to menu on mousedown behavior. (Closed)
|
Created:
4 years, 9 months ago by dgozman Modified:
4 years, 9 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Add 200ms timeout to menu on mousedown behavior.
BUG=594524
Committed: https://crrev.com/b18dcbd20c61ba22fd430bbbf0066f738d480a66
Cr-Commit-Position: refs/heads/master@{#381466}
Patch Set 1 #
Total comments: 4
Patch Set 2 : improved #
Total comments: 2
Messages
Total messages: 19 (8 generated)
dgozman@chromium.org changed reviewers: + caseq@chromium.org
Take a look please.
lgtm https://codereview.chromium.org/1809543002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right): https://codereview.chromium.org/1809543002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:671: if (this._triggerTimeout) { nit: if (!this._triggerTimeout) return; https://codereview.chromium.org/1809543002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:673: delete this._triggerTimeout; this is redundant.
https://codereview.chromium.org/1809543002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right): https://codereview.chromium.org/1809543002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:671: if (this._triggerTimeout) { On 2016/03/16 00:12:00, caseq wrote: > nit: > if (!this._triggerTimeout) > return; Done. https://codereview.chromium.org/1809543002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:673: delete this._triggerTimeout; On 2016/03/16 00:12:00, caseq wrote: > this is redundant. Done.
The CQ bit was checked by dgozman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/1809543002/#ps20001 (title: "improved")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809543002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809543002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Add 200ms timeout to menu on mousedown behavior. BUG=594524 ========== to ========== [DevTools] Add 200ms timeout to menu on mousedown behavior. BUG=594524 Committed: https://crrev.com/b18dcbd20c61ba22fd430bbbf0066f738d480a66 Cr-Commit-Position: refs/heads/master@{#381466} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b18dcbd20c61ba22fd430bbbf0066f738d480a66 Cr-Commit-Position: refs/heads/master@{#381466}
Message was sent while issue was closed.
phistuck@gmail.com changed reviewers: + phistuck@gmail.com
Message was sent while issue was closed.
https://codereview.chromium.org/1809543002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right): https://codereview.chromium.org/1809543002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:656: delete this._triggerTimeout; As far as I know, delete foo; is discouraged because it "rebuilds the world" (so optimizations may have to be re-compiled?) and hurts performance. Perhaps just this._triggerTimeout = 0;?
Message was sent while issue was closed.
See http://jsperf.com/delete-vs-undefined-vs-null/67 - it is an order of magnitude faster (and that does not even show re-compilation consequences of larger functions).
Message was sent while issue was closed.
pfeldman@chromium.org changed reviewers: + pfeldman@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/1809543002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right): https://codereview.chromium.org/1809543002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:656: delete this._triggerTimeout; On 2016/03/16 18:04:48, PhistucK wrote: > As far as I know, delete foo; is discouraged because it "rebuilds the world" (so > optimizations may have to be re-compiled?) and hurts performance. > > Perhaps just this._triggerTimeout = 0;? This code path will never be optimized in the first place and delete property is something we carry from the WebKit times. |
