Support serialization of WorldImpact

tests/compiler/dart2js/serialization_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.serialization_test;
 
 import 'dart:io';
 import 'memory_compiler.dart';
 import 'package:async_helper/async_helper.dart';
 import 'package:compiler/src/constants/constructors.dart';
@@ skipping 324 matching lines @@
     throw "$object1.$property = '${value1}' <> "
           "$object2.$property = '${value2}'";
   }
 }
 
 /// Visitor that checks for equivalence of [Element] identities.
 class ElementIdentityEquivalence extends BaseElementVisitor<dynamic, Element> {
   const ElementIdentityEquivalence();
 
   void visit(Element element1, Element element2) {
+    if (element1 == null && element2 == null) return;
+    if (element1 == element2) return;
+    element1 = element1.declaration;
+    element2 = element2.declaration;
     check(element1, element2, 'kind', element1.kind, element2.kind);
     element1.accept(this, element2);
   }
 
   @override
   void visitElement(Element e, Element arg) {
     throw new UnsupportedError("Unsupported element $e");
   }
 
   @override
@@ skipping 92 matching lines @@
           element1.name, element2.name);
     visit(element1.library, element2.library);
   }
 }
 
 /// Visitor that checks for equivalence of [Element] properties.
 class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
   const ElementPropertyEquivalence();
 
   void visit(Element element1, Element element2) {
+    if (element1 == null && element2 == null) return;

[Siggi Cherem (dart-lang), 2016/03/17 15:33:45]

wouldn't this be covered by the condition below? or did you mean "||"?

[Johnni Winther, 2016/03/18 08:11:32]

Moved `if (element1 == element2) ...` below `e = e.declaration`.

     if (element1 == element2) return;
+    element1 = element1.declaration;
+    element2 = element2.declaration;
     check(element1, element2, 'kind', element1.kind, element2.kind);
     element1.accept(this, element2);
   }
 
   @override
   void visitElement(Element e, Element arg) {
     throw new UnsupportedError("Unsupported element $e");
   }
 
   @override
@@ skipping 48 matching lines @@
     element2.forEachLocalMember((Element member) {
       members2.add(member);
     });
     checkElementListIdentities(
         element1, element2, 'localMembers', members1, members2);
   }
 
   void visitMembers(ScopeContainerElement element1,
                     ScopeContainerElement element2) {
     Set<String> names = new Set<String>();
-    element1.forEachLocalMember((Element member) {
+    Iterable<Element> members1 = element1.isLibrary
+        ? LibrarySerializer.getMembers(element1)
+        : ClassSerializer.getMembers(element1);
+    Iterable<Element> members2 = element2.isLibrary
+        ? LibrarySerializer.getMembers(element2)
+        : ClassSerializer.getMembers(element2);
+    for (Element member in members1) {
       names.add(member.name);
-    });
-    element2.forEachLocalMember((Element member) {
+    }
+    for (Element member in members2) {
       names.add(member.name);
-    });
+    }
+    element1 = element1.implementation;
+    element2 = element2.implementation;
     for (String name in names) {
       Element member1 = element1.localLookup(name);
       Element member2 = element2.localLookup(name);
       if (member1 == null) {
-        print('Missing member for $member2');
+        print('Missing member for $member2 in\n ${members1.join('\n ')}');
         continue;
       }
       if (member2 == null) {
-        print('Missing member for $member1');
+        print('Missing member for $member1 in\n ${members2.join('\n ')}');
         continue;
       }
       visit(member1, member2);
     }
   }
 
   @override
   void visitClassElement(ClassElement element1, ClassElement element2) {
     checkElementIdentities(null, null, null, element1, element2);
     check(element1, element2, 'name',
@@ skipping 524 matching lines @@
         exp1, exp2, 'expression',
         exp1.expression, exp2.expression);
   }
 
   @override
   visitDeferred(DeferredConstantExpression exp1,
                 DeferredConstantExpression exp2) {
     // TODO: implement visitDeferred
   }
 }