third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js - Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js

Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/platform/utilities.js ('K') | « third_party/WebKit/Source/devtools/front_end/script_formatter_worker/CSSFormatter.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js b/third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js

index 47ba177373bdad9ee893d742fe97ee7ca19cba45..45b37c0e81c0c919b36e2c039ebe79cf8a909aa4 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js

@@ -115,7 +115,8 @@ WebInspector.CSSProperty.prototype = {

var range = this.range.relativeTo(this.ownerStyle.range.startLine, this.ownerStyle.range.startColumn);

var indentation = this.ownerStyle.cssText ? this._detectIndentation(this.ownerStyle.cssText) : WebInspector.moduleSetting("textEditorIndent").get();

var endIndentation = this.ownerStyle.cssText ? indentation.substring(0, this.ownerStyle.range.endColumn) : "";

- var newStyleText = range.replaceInText(this.ownerStyle.cssText || "", String.sprintf(";%s;", propertyText));

+ var text = new WebInspector.Text(this.ownerStyle.cssText || "");

+ var newStyleText = text.replaceRange(range, String.sprintf(";%s;", propertyText));

return self.runtime.instancePromise(WebInspector.TokenizerFactory)

.then(this._formatStyle.bind(this, newStyleText, indentation, endIndentation))