third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js - Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js ('K') | « third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js b/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

index 27e62065bb59b8550eb8eda6571525b1a463bcca..a4104f99a9847a749d5bacf81617772a056ab43a 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

@@ -49,8 +49,9 @@ WebInspector.SourceMapNamesResolver._resolveScope = function(scope)

var endLocation = scope.endLocation();

var textRange = new WebInspector.TextRange(startLocation.lineNumber, startLocation.columnNumber, endLocation.lineNumber, endLocation.columnNumber);

- var scopeText = textRange.extract(content);

- var scopeStart = textRange.toSourceRange(content).offset;

+ var text = new WebInspector.Text(content);

+ var scopeText = text.extract(textRange);

+ var scopeStart = text.toSourceRange(textRange).offset;

var prefix = "function fui";

var root = acorn.parse(prefix + scopeText, {});

/** @type {!Array<!ESTree.Node>} */

@@ -212,8 +213,9 @@ WebInspector.SourceMapNamesResolver._resolveExpression = function(callFrame, uiS

if (!content)

return "";

+ var text = new WebInspector.Text(content);

var textRange = sourceMap.reverseMapTextRange(uiSourceCode.url(), new WebInspector.TextRange(lineNumber, startColumnNumber, lineNumber, endColumnNumber));

- var originalText = textRange.extract(content);

+ var originalText = text.extract(textRange);

if (!originalText)

return "";