third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js - Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js

Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/devtools.gypi ('k') | third_party/WebKit/Source/devtools/front_end/common/Text.js » ('j') | third_party/WebKit/Source/devtools/front_end/common/TextRange.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js

diff --git a/third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js b/third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js

index 439ac8868333a153b6e775f4782ad04ed91cbe8d..0a162ba985b20daf03682b96b227a9b2b975f648 100644

--- a/third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js

+++ b/third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js

@@ -79,10 +79,10 @@ WebInspector.ContentProvider.performSearchInContent = function(content, query, c

{

var regex = createSearchRegex(query, caseSensitive, isRegex);

- var contentString = new String(content);

+ var text = new WebInspector.Text(content);

var result = [];

- for (var i = 0; i < contentString.lineCount(); ++i) {

- var lineContent = contentString.lineAt(i);

+ for (var i = 0; i < text.lineCount(); ++i) {

+ var lineContent = text.lineAt(i);

regex.lastIndex = 0;

if (regex.exec(lineContent))

result.push(new WebInspector.ContentProvider.SearchMatch(i, lineContent));