DevTools: remove illusionary caching from String.prototype.lineEndings

third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 WebInspector.SASSSupport = {}
 
 /**
  * @param {!WebInspector.CSSParserService} cssParserService
  * @param {string} url
  * @param {string} text
  * @return {!Promise<!WebInspector.SASSSupport.AST>}
  */
 WebInspector.SASSSupport.parseCSS = function(cssParserService, url, text)
 {
     return cssParserService.parseCSS(text)
         .then(onParsed);
 
     /**
      * @param {!Array.<!WebInspector.CSSParser.Rule>} parsedCSS
      * @return {!WebInspector.SASSSupport.AST}
      */
     function onParsed(parsedCSS)
     {
-        var document = new WebInspector.SASSSupport.ASTDocument(url, text);
+        var document = new WebInspector.SASSSupport.ASTDocument(url, new WebInspector.Text(text));
         var rules = [];
         for (var i = 0; i < parsedCSS.length; ++i) {
             var rule = parsedCSS[i];
             if (!rule.properties)
                 continue;
             var properties = [];
             for (var j = 0; j < rule.properties.length; ++j) {
                 var cssProperty = rule.properties[j];
                 var name = new WebInspector.SASSSupport.TextNode(document, cssProperty.name, WebInspector.TextRange.fromObject(cssProperty.nameRange));
                 var value = new WebInspector.SASSSupport.TextNode(document, cssProperty.value, WebInspector.TextRange.fromObject(cssProperty.valueRange));
                 var property = new WebInspector.SASSSupport.Property(document, name, value, WebInspector.TextRange.fromObject(cssProperty.range), !!cssProperty.disabled);
                 properties.push(property);
             }
             rules.push(new WebInspector.SASSSupport.Rule(document, rule.selectorText, WebInspector.TextRange.fromObject(rule.styleRange), properties));
         }
         return new WebInspector.SASSSupport.AST(document, rules);
     }
 }
 
 /**
  * @param {!WebInspector.TokenizerFactory} tokenizerFactory
  * @param {string} url
  * @param {string} text
  * @return {!WebInspector.SASSSupport.AST}
  */
 WebInspector.SASSSupport.parseSCSS = function(tokenizerFactory, url, text)
 {
-    var document = new WebInspector.SASSSupport.ASTDocument(url, text);
+    var document = new WebInspector.SASSSupport.ASTDocument(url, new WebInspector.Text(text));
     var result = WebInspector.SASSSupport._innerParseSCSS(document, tokenizerFactory);
 
     var rules = [
         new WebInspector.SASSSupport.Rule(document, "variables", WebInspector.TextRange.createFromLocation(0, 0), result.variables),
         new WebInspector.SASSSupport.Rule(document, "properties", WebInspector.TextRange.createFromLocation(0, 0), result.properties),
         new WebInspector.SASSSupport.Rule(document, "mixins", WebInspector.TextRange.createFromLocation(0, 0), result.mixins)
     ];
 
     return new WebInspector.SASSSupport.AST(document, rules);
 }
@@ skipping 10 matching lines @@
     Media: "Media"
 }
 
 /**
  * @param {!WebInspector.SASSSupport.ASTDocument} document
  * @param {!WebInspector.TokenizerFactory} tokenizerFactory
  * @return {!{variables: !Array<!WebInspector.SASSSupport.Property>, properties: !Array<!WebInspector.SASSSupport.Property>, mixins: !Array<!WebInspector.SASSSupport.Property>}}
  */
 WebInspector.SASSSupport._innerParseSCSS = function(document, tokenizerFactory)
 {
-    var lines = document.text.split("\n");
+    var lines = document.text.value().split("\n");
     var properties = [];
     var variables = [];
     var mixins = [];
 
     var States = WebInspector.SASSSupport.SCSSParserStates;
     var state = States.Initial;
     var propertyName, propertyValue;
     var variableName, variableValue;
     var mixinName, mixinValue;
     var UndefTokenType = {};
@@ skipping 17 matching lines @@
                 state = States.PropertyName;
             } else if (tokenType["css-def"] && tokenValue === "@include") {
                 mixinName = new WebInspector.SASSSupport.TextNode(document, tokenValue, new WebInspector.TextRange(lineNumber, column, lineNumber, newColumn));
                 state = States.MixinName;
             } else if (tokenType["css-comment"]) {
                 // Support only a one-line comments.
                 if (tokenValue.substring(0, 2) !== "/*" || tokenValue.substring(tokenValue.length - 2) !== "*/")
                     break;
                 var uncommentedText = tokenValue.substring(2, tokenValue.length - 2);
                 var fakeRuleText = "a{\n" + uncommentedText + "}";
-                var fakeDocument = new WebInspector.SASSSupport.ASTDocument("", fakeRuleText);
+                var fakeDocument = new WebInspector.SASSSupport.ASTDocument("", new WebInspector.Text(fakeRuleText));
                 var result = WebInspector.SASSSupport._innerParseSCSS(fakeDocument, tokenizerFactory);
                 if (result.properties.length === 1 && result.variables.length === 0 && result.mixins.length === 0) {
                     var disabledProperty = result.properties[0];
                     // We should offset property to current coordinates.
                     var offset = column + 2;
                     var nameRange = new WebInspector.TextRange(lineNumber, disabledProperty.name.range.startColumn + offset,
                             lineNumber, disabledProperty.name.range.endColumn + offset);
                     var valueRange = new WebInspector.TextRange(lineNumber, disabledProperty.value.range.startColumn + offset,
                             lineNumber, disabledProperty.value.range.endColumn + offset);
                     var name = new WebInspector.SASSSupport.TextNode(document, disabledProperty.name.text, nameRange);
@@ skipping 98 matching lines @@
     return {
         variables: variables,
         properties: properties,
         mixins: mixins
     };
 }
 
 /**
  * @constructor
  * @param {string} url
- * @param {string} text
+ * @param {!WebInspector.Text} text
  */
 WebInspector.SASSSupport.ASTDocument = function(url, text)
 {
     this.url = url;
     this.text = text;
     this.edits = [];
 }
 
 WebInspector.SASSSupport.ASTDocument.prototype = {
     /**
      * @return {!WebInspector.SASSSupport.ASTDocument}
      */
     clone: function()
     {
         return new WebInspector.SASSSupport.ASTDocument(this.url, this.text);
     },
 
     /**
      * @return {boolean}
      */
     hasChanged: function()
     {
         return !!this.edits.length;
     },
 
     /**
-     * @return {string}
+     * @return {!WebInspector.Text}
      */
     newText: function()
     {
         this.edits.stableSort(sequentialOrder);
         var text = this.text;
         for (var i = this.edits.length - 1; i >= 0; --i)
             text = this.edits[i].applyToText(text);
         return text;
 
         /**
@@ skipping 137 matching lines @@
         this.disabled = disabled;
         if (disabled) {
             var oldRange1 = WebInspector.TextRange.createFromLocation(this.range.startLine, this.range.startColumn);
             var edit1 = new WebInspector.SourceEdit(this.document.url, oldRange1, "/* ");
             var oldRange2 = WebInspector.TextRange.createFromLocation(this.range.endLine, this.range.endColumn);
             var edit2 = new WebInspector.SourceEdit(this.document.url, oldRange2, " */");
             this.document.edits.push(edit1, edit2);
             return;
         }
         var oldRange1 = new WebInspector.TextRange(this.range.startLine, this.range.startColumn, this.range.startLine, this.name.range.startColumn);
-        var text = this.document.text;
         var edit1 = new WebInspector.SourceEdit(this.document.url, oldRange1, "");
         var oldRange2 = new WebInspector.TextRange(this.range.endLine, this.range.endColumn - 2, this.range.endLine, this.range.endColumn);
         var edit2 = new WebInspector.SourceEdit(this.document.url, oldRange2, "");
         this.document.edits.push(edit1, edit2);
     },
 
     remove: function()
     {
         console.assert(this.parent);
         var rule = this.parent;
         var index = rule.properties.indexOf(this);
         rule.properties.splice(index, 1);
         this.parent = null;
 
         var lineRange = new WebInspector.TextRange(this.range.startLine, 0, this.range.endLine + 1, 0);
         var oldRange;
-        if (lineRange.extract(this.document.text).trim() === this.range.extract(this.document.text).trim())
+        if (this.document.text.extract(lineRange).trim() === this.document.text.extract(this.range).trim())
             oldRange = lineRange;
         else
             oldRange = this.range;
         this.document.edits.push(new WebInspector.SourceEdit(this.document.url, oldRange, ""));
     },
 
     __proto__: WebInspector.SASSSupport.Node.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.SASSSupport.Node}
  * @param {!WebInspector.SASSSupport.ASTDocument} document
  * @param {string} selector
  * @param {!WebInspector.TextRange} styleRange
  * @param {!Array<!WebInspector.SASSSupport.Property>} properties
  */
 WebInspector.SASSSupport.Rule = function(document, selector, styleRange, properties)
 {
     WebInspector.SASSSupport.Node.call(this, document);
     this.selector = selector;
     this.properties = properties;
     this.styleRange = styleRange;
     for (var i = 0; i < this.properties.length; ++i)
         this.properties[i].parent = this;
 
-    this._hasTrailingSemicolon = !this.properties.length || this.properties.peekLast().range.extract(this.document.text).endsWith(";");
+    this._hasTrailingSemicolon = !this.properties.length || this.document.text.extract(this.properties.peekLast().range).endsWith(";");
 }
 
 WebInspector.SASSSupport.Rule.prototype = {
     /**
      * @param {!WebInspector.SASSSupport.ASTDocument} document
      * @return {!WebInspector.SASSSupport.Rule}
      */
     clone: function(document)
     {
         var properties = [];
@@ skipping 77 matching lines @@
      * @param {string} nameText
      * @param {string} valueText
      * @param {boolean} disabled
      * @param {!WebInspector.SASSSupport.Property} anchorProperty
      * @param {boolean} insertBefore
      * @return {!WebInspector.SourceEdit}
      */
     _insertPropertyEdit: function(nameText, valueText, disabled, anchorProperty, insertBefore)
     {
         var oldRange = insertBefore ? anchorProperty.range.collapseToStart() : anchorProperty.range.collapseToEnd();
-        var indent = (new WebInspector.TextRange(anchorProperty.range.startLine, 0, anchorProperty.range.startLine, anchorProperty.range.startColumn)).extract(this.document.text);
+        var indent = this.document.text.extract(new WebInspector.TextRange(anchorProperty.range.startLine, 0, anchorProperty.range.startLine, anchorProperty.range.startColumn));
         if (!/^\s+$/.test(indent)) indent = "";
 
         var newText = "";
         var leftComment = disabled ? "/* " : "";
         var rightComment = disabled ? " */" : "";
 
         if (insertBefore) {
             newText = String.sprintf("%s%s: %s;%s\n%s", leftComment, nameText, valueText, rightComment, indent);
         } else {
             newText = String.sprintf("\n%s%s%s: %s;%s", indent, leftComment, nameText, valueText, rightComment);
@@ skipping 225 matching lines @@
         mapping.set(oldProperty.name, newProperty.name);
         mapping.set(oldProperty.value, newProperty.value);
         if (oldProperty.name.text.trim() !== newProperty.name.text.trim())
             addChange(T.NameChanged, oldRule, newRule, oldPropertyIndex, newPropertyIndex);
         if (oldProperty.value.text.trim() !== newProperty.value.text.trim())
             addChange(T.ValueChanged, oldRule, newRule, oldPropertyIndex, newPropertyIndex);
         if (oldProperty.disabled !== newProperty.disabled)
             addChange(T.PropertyToggled, oldRule, newRule, oldPropertyIndex, newPropertyIndex);
     }
 }