DevTools: remove illusionary caching from String.prototype.lineEndings

third_party/WebKit/Source/devtools/front_end/platform/utilities.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 94 matching lines @@
  * @return {boolean}
  */
 String.prototype.isWhitespace = function()
 {
     return /^\s*$/.test(this);
 }
 
 /**
  * @return {!Array.<number>}
  */
 String.prototype.lineEndings = function()

[dgozman, 2016/03/16 20:36:48]

Why don't we remove this method?

[lushnikov, 2016/03/16 21:04:01]

It still comes handy in formatter worker.

 {
-    if (!this._lineEndings) {
-        this._lineEndings = this.findAll("\n");
-        this._lineEndings.push(this.length);
-    }
-    return this._lineEndings;
+    var endings = this.findAll("\n");
+    endings.push(this.length);
+    return endings;
 }
 
 /**
- * @return {number}
- */
-String.prototype.lineCount = function()
-{
-    var lineEndings = this.lineEndings();
-    return lineEndings.length;
-}
-
-/**
- * @param {number} lineNumber
- * @param {number} columNumber
- * @return {number}
- */
-String.prototype.offsetFromPosition = function(lineNumber, columNumber)
-{
-    return (lineNumber ? this.lineEndings()[lineNumber - 1] + 1 : 0) + columNumber;
-}
-
-/**
- * @return {string}
- */
-String.prototype.lineAt = function(lineNumber)
-{
-    var lineEndings = this.lineEndings();
-    var lineStart = lineNumber > 0 ? lineEndings[lineNumber - 1] + 1 : 0;
-    var lineEnd = lineEndings[lineNumber];
-    var lineContent = this.substring(lineStart, lineEnd);
-    if (lineContent.length > 0 && lineContent.charAt(lineContent.length - 1) === "\r")
-        lineContent = lineContent.substring(0, lineContent.length - 1);
-    return lineContent;
-}
-
-/**
  * @param {string} chars
  * @return {string}
  */
 String.prototype.escapeCharacters = function(chars)
 {
     var foundChar = false;
     for (var i = 0; i < chars.length; ++i) {
         if (this.indexOf(chars.charAt(i)) !== -1) {
             foundChar = true;
             break;
@@ skipping 1498 matching lines @@
     _tryMerge: function(first, second)
     {
         var merged = this._mergeCallback && this._mergeCallback(first, second);
         if (!merged)
             return null;
         merged.begin = first.begin;
         merged.end = Math.max(first.end, second.end);
         return merged;
     }
 }