DevTools: remove illusionary caching from String.prototype.lineEndings

third_party/WebKit/Source/devtools/front_end/common/TextRange.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 207 matching lines @@
             relative.startColumn -= column;
         if (this.endLine == line)
             relative.endColumn -= column;
 
         relative.startLine -= line;
         relative.endLine -= line;
         return relative;
     },
 
     /**
-     * @param {string} text
-     * @return {!WebInspector.SourceRange}
-     */
-    toSourceRange: function(text)
-    {
-        var start = text.offsetFromPosition(this.startLine, this.startColumn);
-        var end = text.offsetFromPosition(this.endLine, this.endColumn);
-        return new WebInspector.SourceRange(start, end - start);
-    },
-
-    /**
      * @param {!WebInspector.TextRange} originalRange
      * @param {!WebInspector.TextRange} editedRange
      * @return {!WebInspector.TextRange}
      */
     rebaseAfterTextEdit: function(originalRange, editedRange)
     {
         console.assert(originalRange.startLine === editedRange.startLine);
         console.assert(originalRange.startColumn === editedRange.startColumn);
         var rebase = this.clone();
         if (!this.follows(originalRange))
@@ skipping 12 matching lines @@
     /**
      * @override
      * @return {string}
      */
     toString: function()
     {
         return JSON.stringify(this);
     },
 
     /**
-     * @param {string} text
-     * @param {string} replacement
-     * @return {string}
-     */
-    replaceInText: function(text, replacement)
-    {
-        var sourceRange = this.toSourceRange(text);
-        return text.substring(0, sourceRange.offset) + replacement + text.substring(sourceRange.offset + sourceRange.length);
-    },
-
-    /**
-     * @param {string} text
-     * @return {string}
-     */
-    extract: function(text)
-    {
-        var sourceRange = this.toSourceRange(text);
-        return text.substr(sourceRange.offset, sourceRange.length);
-    },
-
-    /**
      * @param {number} lineNumber
      * @param {number} columnNumber
      * @return {boolean}
      */
     containsLocation: function(lineNumber, columnNumber)
     {
         if (this.startLine === this.endLine)
             return this.startLine === lineNumber && this.startColumn <= columnNumber && columnNumber <= this.endColumn;
         if (this.startLine === lineNumber)
             return this.startColumn <= columnNumber;
@@ skipping 31 matching lines @@
  * @param {number} length
  */
 WebInspector.SourceRange = function(offset, length)
 {
     this.offset = offset;
     this.length = length;
 }
 
 WebInspector.SourceRange.prototype = {
     /**
-     * @param {string} text
+     * @param {!WebInspector.Text} text
      * @return {!WebInspector.TextRange}
      */
     toTextRange: function(text)
     {
         var p1 = fromOffset(text, this.offset);
         var p2 = fromOffset(text, this.offset + this.length);
         return new WebInspector.TextRange(p1.lineNumber, p1.columnNumber, p2.lineNumber, p2.columnNumber);
 
         /**
-         * @param {string} text
+         * @param {!WebInspector.Text} text
          * @param {number} offset
          * @return {!{lineNumber: number, columnNumber: number}}
          */
         function fromOffset(text, offset)
         {
             var lineEndings = text.lineEndings();
             var lineNumber = lineEndings.lowerBound(offset);
             var columnNumber = lineNumber === 0 ? offset : offset - lineEndings[lineNumber - 1] - 1;
             return {lineNumber: lineNumber, columnNumber: columnNumber};
         }
@@ skipping 16 matching lines @@
 WebInspector.SourceEdit.prototype = {
     /**
      * @return {!WebInspector.TextRange}
      */
     newRange: function()
     {
         return WebInspector.TextRange.fromEdit(this.oldRange, this.newText);
     },
 
     /**
-     * @param {string} text
-     * @return {string}
+     * @param {!WebInspector.Text} text
+     * @return {!WebInspector.Text}
      */
     applyToText: function(text)

[dgozman, 2016/03/16 20:36:48]

Is this one used?

[lushnikov, 2016/03/16 21:04:01]

There was a single client; i inlined it and removed the method.

     {
-        return this.oldRange.replaceInText(text, this.newText);
+        return new WebInspector.Text(text.replaceRange(this.oldRange, this.newText));
     },
 }