Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: trunk/Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 180953009: Revert 168554 "Reduce compositing update in Silk's toggle_drawer..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/Source/core/rendering/compositing/CompositedLayerMapping.cpp
===================================================================
--- trunk/Source/core/rendering/compositing/CompositedLayerMapping.cpp (revision 168555)
+++ trunk/Source/core/rendering/compositing/CompositedLayerMapping.cpp (working copy)
@@ -421,7 +421,7 @@
layerCompositor->updateCompositingDescendantGeometry(m_owningLayer->stackingNode(), m_owningLayer, flags & CompositingChildrenOnly);
if (flags & IsUpdateRoot) {
- updateGraphicsLayerGeometry(GraphicsLayerUpdater::ForceUpdate);
+ updateGraphicsLayerGeometry();
layerCompositor->updateRootLayerPosition();
RenderLayerStackingNode* stackingContainer = m_owningLayer->stackingNode()->enclosingStackingContainerNode();
if (!layerCompositor->compositingLayersNeedRebuild() && stackingContainer && (stackingContainer != m_owningLayer->stackingNode()))
@@ -617,18 +617,12 @@
}
}
-GraphicsLayerUpdater::UpdateType CompositedLayerMapping::updateGraphicsLayerGeometry(GraphicsLayerUpdater::UpdateType updateType)
+void CompositedLayerMapping::updateGraphicsLayerGeometry()
{
// If we haven't built z-order lists yet, wait until later.
if (m_owningLayer->stackingNode()->isStackingContainer() && m_owningLayer->stackingNode()->zOrderListsDirty())
- return updateType;
+ return;
- if (!m_needToUpdateGeometry && updateType != GraphicsLayerUpdater::ForceUpdate)
- return updateType;
- m_needToUpdateGeometry = false;
- if (m_needToUpdateGeometryOfAllDecendants)
- updateType = GraphicsLayerUpdater::ForceUpdate;
-
// Set transform property, if it is not animating. We have to do this here because the transform
// is affected by the layer dimensions.
if (!hasActiveAnimationsOnCompositor(*renderer(), CSSPropertyWebkitTransform))
@@ -789,7 +783,7 @@
if (m_owningLayer->reflectionInfo() && m_owningLayer->reflectionInfo()->reflectionLayer()->hasCompositedLayerMapping()) {
CompositedLayerMappingPtr reflectionCompositedLayerMapping = m_owningLayer->reflectionInfo()->reflectionLayer()->compositedLayerMapping();
- reflectionCompositedLayerMapping->updateGraphicsLayerGeometry(GraphicsLayerUpdater::ForceUpdate);
+ reflectionCompositedLayerMapping->updateGraphicsLayerGeometry();
// The reflection layer has the bounds of m_owningLayer->reflectionLayer(),
// but the reflected layer is the bounds of this layer, so we need to position it appropriately.
@@ -868,8 +862,6 @@
registerScrollingLayers();
updateCompositingReasons();
-
- return updateType;
}
void CompositedLayerMapping::registerScrollingLayers()
@@ -1857,28 +1849,6 @@
}
}
-void CompositedLayerMapping::setNeedsGeometryUpdate()
-{
- m_needToUpdateGeometryOfAllDecendants = true;
-
- for (RenderLayer* current = m_owningLayer; current; current = current->ancestorCompositingLayer()) {
- // FIXME: We should be able to return early from this function once we
- // find a CompositedLayerMapping that has m_needToUpdateGeometry set.
- // However, we can't do that until we remove the incremental compositing
- // updates because they can clear m_needToUpdateGeometry without walking
- // the whole tree.
- ASSERT(current->hasCompositedLayerMapping());
- CompositedLayerMappingPtr mapping = current->compositedLayerMapping();
- mapping->m_needToUpdateGeometry = true;
- }
-}
-
-void CompositedLayerMapping::clearNeedsGeometryUpdate()
-{
- m_needToUpdateGeometry = false;
- m_needToUpdateGeometryOfAllDecendants = false;
-}
-
struct SetContentsNeedsDisplayFunctor {
void operator() (GraphicsLayer* layer) const
{

Powered by Google App Engine
This is Rietveld 408576698