Issue 180953007: NaCl SDK: Remove more unused variables in examples

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180953007: NaCl SDK: Remove more unused variables in examples (Closed)

Created:
6 years, 9 months ago by Mark Seaborn

Modified:
6 years, 9 months ago

Reviewers:
binji

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl SDK: Remove more unused variables in examples PNaCl is being upgraded to Clang 3.4, which now warns about unused declarations inside anonymous namespaces. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3757 TEST=none R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255341

Patch Set 1 #

Patch Set 2 : Undo test-only changes #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	native_client_sdk/src/examples/api/var_dictionary/var_dictionary.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	native_client_sdk/src/examples/demo/earth/earth.cc	View		3 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r255341.

Expand Messages | Collapse Messages