Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1809503003: Begin working on mojom_lang.md for real. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
vardhan, rudominer
CC:
rudominer, mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Begin working on mojom_lang.md for real. (This is reference-ish documentation on Mojom.) There's still a ton of stuff to reorganize/rewrite. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/840291dc2b30782ad567e5cb314ecfe87accbc93

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -110 lines) Patch
M docs/mojom_lang/mojom_lang.md View 2 chunks +232 lines, -110 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
viettrungluu
4 years, 9 months ago (2016-03-15 22:59:31 UTC) #1
vardhan
lgtm (adding rudominer@, since he knows some of these details better) https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang.md File docs/mojom_lang/mojom_lang.md (right): ...
4 years, 9 months ago (2016-03-16 20:17:29 UTC) #2
rudominer
https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang.md File docs/mojom_lang/mojom_lang.md (right): https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang.md#newcode201 docs/mojom_lang/mojom_lang.md:201: "include path"), for the purposes of resolving these paths. ...
4 years, 9 months ago (2016-03-16 21:07:34 UTC) #4
viettrungluu
Thanks, Vardhan and Mitch. I'll update that part on the next iteration. On 2016/03/16 21:07:34, ...
4 years, 9 months ago (2016-03-16 21:55:59 UTC) #5
viettrungluu
4 years, 9 months ago (2016-03-16 21:56:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
840291dc2b30782ad567e5cb314ecfe87accbc93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698