Begin working on mojom_lang.md for real.

Begin working on mojom_lang.md for real.

(This is reference-ish documentation on Mojom.)

There's still a ton of stuff to reorganize/rewrite.

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/840291dc2b30782ad567e5cb314ecfe87accbc93

[vardhan, 2016-03-16 20:17:29]

lgtm (adding rudominer@, since he knows some of these details better)

https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang.md
File docs/mojom_lang/mojom_lang.md (right):

https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang....
docs/mojom_lang/mojom_lang.md:201: "include path"), for the purposes of
resolving these paths. (**TODO(vtl)**: This
rudominer@ should be able to answer this TODO's question

[rudominer, 2016-03-16 21:07:33]

rudominer@chromium.org changed reviewers:
+ rudominer@chromium.org

[rudominer, 2016-03-16 21:07:34]

https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang.md
File docs/mojom_lang/mojom_lang.md (right):

https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang....
docs/mojom_lang/mojom_lang.md:201: "include path"), for the purposes of
resolving these paths. (**TODO(vtl)**: This
On 2016/03/16 20:17:29, vardhan wrote:
> rudominer@ should be able to answer this TODO's question

The comment from parser_driver.go says:

// We attempt to find the file named by a given path, both top-level and
// imported, using the following algorithm:
// (1) If the specified path is an absolute path we use that path
// (2) Otherwise if the file was imported from another file we first attempt
// to find a file with the specified path relative to the directory of the
// importing file
// (3) Otherwise if the file was imported we attempt to find a file with the
// specified path relative to one of the specified import directories.
// (4) Otherwise we attempt to find a file with the specified path relative to
// the current working directory.

[viettrungluu, 2016-03-16 21:55:59]

Thanks, Vardhan and Mitch.

I'll update that part on the next iteration.

On 2016/03/16 21:07:34, rudominer wrote:
>
https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang.md
> File docs/mojom_lang/mojom_lang.md (right):
> 
>
https://codereview.chromium.org/1809503003/diff/1/docs/mojom_lang/mojom_lang....
> docs/mojom_lang/mojom_lang.md:201: "include path"), for the purposes of
> resolving these paths. (**TODO(vtl)**: This
> On 2016/03/16 20:17:29, vardhan wrote:
> > rudominer@ should be able to answer this TODO's question
> 
> The comment from parser_driver.go says:
> 
> // We attempt to find the file named by a given path, both top-level and
> // imported, using the following algorithm:
> // (1) If the specified path is an absolute path we use that path
> // (2) Otherwise if the file was imported from another file we first attempt
> // to find a file with the specified path relative to the directory of the
> // importing file
> // (3) Otherwise if the file was imported we attempt to find a file with the
> // specified path relative to one of the specified import directories.
> // (4) Otherwise we attempt to find a file with the specified path relative to
> // the current working directory.

Some questions (for Mitch):
- Should (3) be something like "For an imported file specified by a relative
path, we try to find it at a path relative to the importing file."? (I.e., you
try to resolve an import statement relative to the file that the statement is
in.)
- (4): Do we really want to check the parser's current working directory? (Do
things like C++ compilers do that?)

[viettrungluu, 2016-03-16 21:56:28]

Description was changed from

==========
Begin working on mojom_lang.md for real.

(This is reference-ish documentation on Mojom.)

There's still a ton of stuff to reorganize/rewrite.

R=vardhan@google.com
==========

to

==========
Begin working on mojom_lang.md for real.

(This is reference-ish documentation on Mojom.)

There's still a ton of stuff to reorganize/rewrite.

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/840291dc2b30782ad567e5cb314...
==========

[viettrungluu, 2016-03-16 21:56:30]

Committed patchset #1 (id:1) manually as
840291dc2b30782ad567e5cb314ecfe87accbc93 (presubmit successful).